filecheck/nonasciiMsg #35

周赵嘉程521432910016 · 2024-09-12T16:11:56+08:00

周赵嘉程521432910016 commented

2024-09-12 16:11:56 +08:00

Fix bug caused by co-author, co-commit msg in pull request.

Fix bug caused by `co-author`, `co-commit` msg in pull request.

王韵晨520370910012 requested changes 2024-09-12 16:21:40 +08:00

Dismissed

王韵晨520370910012 left a comment

suggesting if c.NumParents() > 1

suggesting `if c.NumParents() > 1`

pkg/healthcheck/commit.go Outdated

						
				@ -58,0 +63,4 @@

							trimmedLine := strings.TrimSpace(line)

							ignore := false

							for _, prefix := range ignoredPrefixes {

								if strings.HasPrefix(trimmedLine, prefix) {

周赵嘉程521432910016 commented

2024-09-12 16:22:31 +08:00

I tried with following code and it fails to fix

func NonAsciiMsg(root string) error {
	// cmd := exec.Command("git", "log", "--encoding=UTF-8", "--format=%B")
	repo, err := git.PlainOpen(root)
	if err != nil {
		slog.Error("openning git repo", "err", err)
		return fmt.Errorf("error openning git repo: %v", err)
	}

	ref, err := repo.Head()
	if err != nil {
		slog.Error("getting reference", "err", err)
		return fmt.Errorf("error getting reference: %v", err)
	}
	commits, err := repo.Log(&git.LogOptions{From: ref.Hash()})
	if err != nil {
		slog.Error("getting commits", "err", err)
		return fmt.Errorf("error getting commits from reference %s: %v", ref.Hash(), err)
	}

	var msgs []string
	err = commits.ForEach(func(c *object.Commit) error {
		if c.NumParents() > 1 {
			return nil
		}

		msgs = append(msgs, c.Message)
		return nil
	})

I tried with following code and it fails to fix ```golang func NonAsciiMsg(root string) error { // cmd := exec.Command("git", "log", "--encoding=UTF-8", "--format=%B") repo, err := git.PlainOpen(root) if err != nil { slog.Error("openning git repo", "err", err) return fmt.Errorf("error openning git repo: %v", err) } ref, err := repo.Head() if err != nil { slog.Error("getting reference", "err", err) return fmt.Errorf("error getting reference: %v", err) } commits, err := repo.Log(&git.LogOptions{From: ref.Hash()}) if err != nil { slog.Error("getting commits", "err", err) return fmt.Errorf("error getting commits from reference %s: %v", ref.Hash(), err) } var msgs []string err = commits.ForEach(func(c *object.Commit) error { if c.NumParents() > 1 { return nil } msgs = append(msgs, c.Message) return nil }) ```

周赵嘉程521432910016 commented

2024-09-12 16:39:45 +08:00

won't be too bad, just 4-5 test for each message.

王韵晨520370910012 commented

2024-09-12 16:42:20 +08:00

we may have to fall back to the silly solution...

mac-wang marked this conversation as resolved

周赵嘉程521432910016 force-pushed filecheck/nonasciiMsg from 5c6d4686ac to 0bbb49f2d1

2024-09-12 17:30:25 +08:00

Compare

周赵嘉程521432910016 added 1 commit 2024-09-13 11:51:43 +08:00

Merge branch 'master' into filecheck/nonasciiMsg 875aae3fae