From 870f20dde98d1fe32076ff9129ab76cb5237aeb8 Mon Sep 17 00:00:00 2001 From: Boming Zhang Date: Thu, 27 Feb 2025 01:25:56 -0500 Subject: [PATCH 1/3] chore: remove unused utils --- tests/utils.py | 7 ------- 1 file changed, 7 deletions(-) delete mode 100644 tests/utils.py diff --git a/tests/utils.py b/tests/utils.py deleted file mode 100644 index 7eda07e..0000000 --- a/tests/utils.py +++ /dev/null @@ -1,7 +0,0 @@ -from typing import Any - - -def safe_id(x: Any) -> str: - if not x or not isinstance(x, (tuple, list)) or len(x) == 0: - return "no_test_cases" - return str(x[0]) From ae77fa23b5cf395743317e3744edff7af405c6f2 Mon Sep 17 00:00:00 2001 From: Boming Zhang Date: Thu, 27 Feb 2025 01:26:21 -0500 Subject: [PATCH 2/3] fix: default path for tests --- joj3_config_generator/models/task.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/joj3_config_generator/models/task.py b/joj3_config_generator/models/task.py index 6672d02..a09a069 100644 --- a/joj3_config_generator/models/task.py +++ b/joj3_config_generator/models/task.py @@ -34,7 +34,7 @@ class Release(BaseModel): class Config(BaseModel): root: Path = Path(".") - path: Path = Path("conf.toml") + path: Path = Path("task.toml") task: str # Task name (e.g., hw3 ex5) release: Release # Release configuration stages: List[Stage] # list of stage configurations From aee123601f809bda0216f27aad893dd0e86e9197 Mon Sep 17 00:00:00 2001 From: Boming Zhang Date: Thu, 27 Feb 2025 01:28:43 -0500 Subject: [PATCH 3/3] fix: root path for tests --- tests/convert/utils.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/convert/utils.py b/tests/convert/utils.py index f51f073..0a458a1 100644 --- a/tests/convert/utils.py +++ b/tests/convert/utils.py @@ -11,15 +11,15 @@ from joj3_config_generator.models import repo, task def read_convert_files( case_name: str, ) -> Tuple[repo.Config, task.Config, Dict[str, Any]]: - root = Path(__file__).resolve().parent - repo_toml_path = root / case_name / "repo.toml" + root = Path(__file__).resolve().parent / case_name + repo_toml_path = root / "repo.toml" repo_toml = repo_toml_path.read_text() if repo_toml_path.exists() else "" - task_toml_path = root / case_name / "task.toml" + task_toml_path = root / "task.toml" task_toml = task_toml_path.read_text() if task_toml_path.exists() else "" - result = json.loads((root / case_name / "task.json").read_text()) + result = json.loads((root / "task.json").read_text()) return ( - repo.Config(**rtoml.loads(repo_toml)), - task.Config(**rtoml.loads(task_toml)), + repo.Config(root=root, **rtoml.loads(repo_toml)), + task.Config(root=root, **rtoml.loads(task_toml)), result, )