Integration and enhancement on config generator development #2

New Issue

李衍志523370910113 · 2024-10-19T22:25:31+08:00

李衍志523370910113 commented

2024-10-19 22:25:31 +08:00

Current file structure

lib contains every function that is needed
src only contains main to run
toml contains sample toml in https://focs.ji.sjtu.edu.cn/git/JOJ/JOJ3/wiki/JOJ3-Configuration-For-TAs
output temporarily json would be output here
the sample toml files are able to be translated to json files, we have a output/sample.json generated by toml/task_complex now.

features haven't been implemented

release expire time
release specify stages to run

After looking at the file structures of master, I realize that I need to integrate dev in to master, and also I guess some part of my code can be enhanced. So @manuel @bomingzh can you please help and take a look, and help improve the code and manage to merge dev into master?

## Current file structure - `lib` contains every function that is needed - `src` only contains `main` to run - `toml` contains sample toml in https://focs.ji.sjtu.edu.cn/git/JOJ/JOJ3/wiki/JOJ3-Configuration-For-TAs - `output` temporarily json would be output here - the sample toml files are able to be translated to json files, we have a `output/sample.json` generated by `toml/task_complex` now. ## features haven't been implemented - release expire time - release specify stages to run After looking at the file structures of master, I realize that I need to integrate dev in to master, and also I guess some part of my code can be enhanced. So @manuel @bomingzh can you please help and take a look, and help improve the code and manage to merge dev into master?

manuel was assigned by 李衍志523370910113

2024-10-19 22:25:41 +08:00

张泊明518370910136 was assigned by 李衍志523370910113

2024-10-19 22:25:45 +08:00

李衍志523370910113 self-assigned this 2024-10-19 22:25:48 +08:00

张泊明518370910136 commented

2024-10-20 04:43:09 +08:00

Rebase dev branch on master branch, follow the readme on master branch.
Move test files (these toml and json files) to tests and write test cases.
Add tmp files to .gitignore.
Move lib into joj3_config_generator.
Put src/main.py to joj3_config_generator/main.py, make the cli app run with pdm run app create.
Make it pass pdm run all.
Commit.

0. Rebase `dev` branch on `master` branch, follow the readme on master branch. 1. Move test files (these toml and json files) to `tests` and write test cases. 2. Add tmp files to `.gitignore`. 3. Move `lib` into `joj3_config_generator`. 4. Put `src/main.py` to `joj3_config_generator/main.py`, make the cli app run with `pdm run app create`. 5. Make it pass `pdm run all`. 6. Commit.

manuel commented

2024-10-26 12:25:16 +08:00

should now be fine, closing

manuel closed this issue

2024-10-26 12:25:16 +08:00

Sign in to join this conversation.