JOJ/JOJ3-config-generator
27
1
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat: support overwrite of groups & max_total_score in task.toml #22

Merged
李衍志523370910113 merged 2 commits from feat/tomlfield into master 2025-06-10 15:39:13 +08:00
Conversation 0 Commits 2 Files Changed 6 +50 -14
李衍志523370910113 commented 2025-06-10 14:55:35 +08:00
Member
Copy Link

support #21

support https://focs.ji.sjtu.edu.cn/git/JOJ/JOJ3-config-generator/issues/21
李衍志523370910113 added 1 commit 2025-06-10 14:55:36 +08:00
feat: support overwrite of groups & max_total_score in
All checks were successful
build / build (push) Successful in 1m53s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Successful in 1m46s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
031f8e38d0
张泊明518370910136 was assigned by 李衍志523370910113 2025-06-10 14:56:13 +08:00
李衍志523370910113 self-assigned this 2025-06-10 14:56:17 +08:00
李衍志523370910113 scheduled this pull request to auto merge when all checks succeed 2025-06-10 14:58:40 +08:00
李衍志523370910113 added the
enhancement
 label 2025-06-10 15:04:03 +08:00
张泊明518370910136 reviewed 2025-06-10 15:19:52 +08:00
tests/convert/basic/task.toml Outdated
@ -1,9 +1,15 @@
# general task configuration
task.name = "hw7 ex2" # task name
max_total_score = 10245871
张泊明518370910136 commented 2025-06-10 15:19:52 +08:00
Owner
Copy Link

should use max-total-score here for consistency

should use `max-total-score` here for consistency
李衍志523370910113 commented 2025-06-10 15:32:55 +08:00
Author
Member
Copy Link

fixed now 🙂

fixed now 🙂
jon-lee marked this conversation as resolved
李衍志523370910113 reviewed 2025-06-10 15:26:01 +08:00
tests/convert/basic/task.json
@ -5,3 +5,3 @@
"effectiveUnixTimestamp": 1735487999,
"actorCsvPath": "/home/tt/.config/joj/students.csv",
"maxTotalScore": 100,
"maxTotalScore": 10245871,
李衍志523370910113 commented 2025-06-10 14:57:49 +08:00
Author
Member
Copy Link

@bomingzh is this already outdated? Shall I remove it?

@bomingzh is this already outdated? Shall I remove it?
张泊明518370910136 commented 2025-06-10 15:28:18 +08:00
Owner
Copy Link

what?

what?
李衍志523370910113 commented 2025-06-10 15:32:13 +08:00
Author
Member
Copy Link

oh, my bad, the other one is for giving message to teapot 😃

oh, my bad, the other one is for giving message to `teapot` 😃
jon-lee marked this conversation as resolved
李衍志523370910113 added 1 commit 2025-06-10 15:31:04 +08:00
chore: consistent style
All checks were successful
build / build (pull_request) Successful in 2m0s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
build / build (push) Successful in 2m26s
Details
build / trigger-build-image (push) Has been skipped
Details
083a594a99
李衍志523370910113 scheduled this pull request to auto merge when all checks succeed 2025-06-10 15:33:21 +08:00
张泊明518370910136 approved these changes 2025-06-10 15:39:12 +08:00
李衍志523370910113 merged commit f72189dc81 into master 2025-06-10 15:39:13 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
张泊明518370910136
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
张泊明518370910136
李衍志523370910113
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: JOJ/JOJ3-config-generator#22
No description provided.
Delete Branch "feat/tomlfield"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?