JOJ/JOJ3-config-generator
27
1
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

dev #10

Merged
李衍志523370910113 merged 238 commits from dev into master 2025-03-05 16:20:39 +08:00
Conversation 16 Commits 238 Files Changed 42 +1 -2
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 591d6d552e - Show all commits

3
joj3_config_generator/models/task.py
View File

@ -82,8 +82,7 @@ class Stage(BaseModel):
cases: Optional[Dict[str, "Stage"]] = None
diff: Optional[ParserDiff] = ParserDiff()
class Config:
extra = "allow"
model_config = {"extra": "allow"}
jon-lee marked this conversation as resolved Outdated
张泊明518370910136 commented 2025-02-25 10:40:11 +08:00
Outdated
Review
Copy Link

deprecated

deprecated
李衍志523370910113 commented 2025-02-25 11:02:07 +08:00
Outdated
Review
Copy Link

@bomingzh any suggestions on the structure?

@bomingzh any suggestions on the structure?
张泊明518370910136 commented 2025-02-25 11:18:39 +08:00
Outdated
Review
Copy Link
PydanticDeprecatedSince20: Support for class-based `config` is deprecated, use ConfigDict instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.9/migration/
``` PydanticDeprecatedSince20: Support for class-based `config` is deprecated, use ConfigDict instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.9/migration/ ```
李衍志523370910113 commented 2025-02-25 14:17:34 +08:00
Outdated
Review
Copy Link

fixed with model_config

fixed with `model_config`
张泊明518370910136 commented 2025-03-05 10:05:48 +08:00
Outdated
Review
Copy Link

str here need to be a StrEnum now.

str here need to be a `StrEnum` now.
李衍志523370910113 commented 2025-03-05 11:33:58 +08:00
Outdated
Review
Copy Link

But I guess we don't know the set of case in advance, making it dynamic StrEnum is meaningless

But I guess we don't know the set of case in advance, making it dynamic `StrEnum` is meaningless
张泊明518370910136 commented 2025-03-05 11:39:06 +08:00
Outdated
Review
Copy Link

line changed, the comment is for parsers

line changed, the comment is for `parsers`
@model_validator(mode="before")
jon-lee marked this conversation as resolved Outdated
李衍志523370910113 commented 2025-03-05 11:43:07 +08:00
Outdated
Review
Copy Link

this should be the StrEnum

this should be the `StrEnum`
李衍志523370910113 commented 2025-03-05 13:05:31 +08:00
Outdated
Review
Copy Link

It is supported now.

It is supported now.
@classmethod