JOJ/JOJ3-config-generator
27
1
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

dev #10

Merged
李衍志523370910113 merged 238 commits from dev into master 2025-03-05 16:20:39 +08:00
Conversation 16 Commits 238 Files Changed 42 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5a6cfd1475 - Show all commits

2
joj3_config_generator/processers/task.py
View File

@ -76,7 +76,7 @@ def get_executor_with(
copy_in={
jon-lee marked this conversation as resolved Outdated
张泊明518370910136 commented 2025-03-03 11:22:55 +08:00
Outdated
Review
Copy Link

do not use getattr, visit the field explictly

do not use `getattr`, visit the field explictly
李衍志523370910113 commented 2025-03-03 12:48:04 +08:00
Outdated
Review
Copy Link

resolved.

resolved.
file: result.LocalFile(src=str(JOJ3_CONFIG_ROOT / file))
# all copyin files store in this tools folder
# are there any corner cases
# TODO: are there any corner cases?
jon-lee marked this conversation as resolved Outdated
张泊明518370910136 commented 2025-03-05 16:06:12 +08:00
Outdated
Review
Copy Link

is there a conclusion now? or it should have a prefix TODO: ?

is there a conclusion now? or it should have a prefix `TODO: `?
李衍志523370910113 commented 2025-03-05 16:09:52 +08:00
Outdated
Review
Copy Link

so far works fine on 280 sides, indicating that pbs in 151 can be resolved with proper guidelines I think.

so far works fine on 280 sides, indicating that pbs in 151 can be resolved with proper guidelines I think.
张泊明518370910136 commented 2025-03-05 16:11:11 +08:00
Outdated
Review
Copy Link

ok, then add that prefix

ok, then add that prefix
for file in copy_in_files
jon-lee marked this conversation as resolved Outdated
张泊明518370910136 commented 2025-03-02 02:20:52 +08:00
Outdated
Review
Copy Link

is it in the correct unit?
Give all the fields in Limit a default value and make it non optional in task_stage.limit

is it in the correct unit? Give all the fields in `Limit` a default value and make it non optional in task_stage.limit
李衍志523370910113 commented 2025-03-02 11:47:43 +08:00
Outdated
Review
Copy Link

resolved

resolved
},
copy_out=copy_out_files,