dev #10
|  | @ -1,5 +1,5 @@ | |||
| from datetime import datetime, timedelta | ||||
| 
					
					jon-lee marked this conversation as resolved
					
						
						
							Outdated
						
					
				 | ||||
| from enum import StrEnum | ||||
| from enum import Enum | ||||
| from pathlib import Path | ||||
| from typing import Any, Dict, List, Type | ||||
| 
 | ||||
|  | @ -81,7 +81,7 @@ class Limit(BaseModel): | |||
|         raise ValueError("Must be a string") | ||||
| 
 | ||||
| 
 | ||||
| class Parser(StrEnum): | ||||
| class Parser(str, Enum): | ||||
|     CLANG_TIDY = "clangtidy" | ||||
| 
					
					jon-lee marked this conversation as resolved
					
						
						
							Outdated
						
					
				 
				
					
						张泊明518370910136
						commented  deprecated deprecated 
				
					
						李衍志523370910113
						commented  @bomingzh any suggestions on the structure? @bomingzh any suggestions on the structure? 
				
					
						张泊明518370910136
						commented  ```
PydanticDeprecatedSince20: Support for class-based `config` is deprecated, use ConfigDict instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.9/migration/
``` 
				
					
						李衍志523370910113
						commented  fixed with  fixed with `model_config` 
				
					
						张泊明518370910136
						commented  str here need to be a  str here need to be a `StrEnum` now. 
				
					
						李衍志523370910113
						commented  But I guess we don't know the set of case in advance, making it dynamic  But I guess we don't know the set of case in advance, making it dynamic `StrEnum` is meaningless 
				
					
						张泊明518370910136
						commented  line changed, the comment is for  line changed, the comment is for `parsers` | ||||
|     CPPCHECK = "cppcheck" | ||||
|     CPPLINT = "cpplint" | ||||
| 
					
					jon-lee marked this conversation as resolved
					
						
						
							Outdated
						
					
				 
				
					
						李衍志523370910113
						commented  this should be the  this should be the `StrEnum` 
				
					
						张泊明518370910136
						commented  yes yes 
				
					
						李衍志523370910113
						commented  It is supported now. It is supported now. | ||||
|  |  | |||
|  | @ -11,10 +11,10 @@ dependencies = [ | |||
|     "loguru>=0.7.2", | ||||
|     "pydantic>=2.9.2", | ||||
|     "inquirer>=3.4.0", | ||||
|     "rtoml>=0.12.0", | ||||
|     "rtoml>=0.11.0", | ||||
|     "humanfriendly>=10.0", | ||||
| ] | ||||
| requires-python = ">=3.11" | ||||
| requires-python = ">=3.9" | ||||
| authors = [{ name = "JOJ3-dev", email = "joj3@focs.ji.sjtu.edu.cn" }] | ||||
| maintainers = [] | ||||
| description = "JOJ3 json configuration file generator" | ||||
|  |  | |||
		Loading…
	
		Reference in New Issue
	
	Block a user
	
every field in this file should not be optional. we give an default value here if any field does not exist
and use underscore naming in this file
fixed
fixed.