JOJ/JOJ3-config-generator
27
1
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

dev #10

Merged
李衍志523370910113 merged 238 commits from dev into master 2025-03-05 16:20:39 +08:00
Conversation 16 Commits 238 Files Changed 42 +2 -3
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6ee7068bfa - Show all commits

3
joj3_config_generator/processers/repo.py
View File

@ -54,8 +54,7 @@ def get_teapot_check_args(repo_conf: repo.Config) -> List[str]:
+ f"{repo_conf.groups.max_count[i]}:"
jon-lee marked this conversation as resolved Outdated
张泊明518370910136 commented 2025-03-02 02:30:17 +08:00
Outdated
Review
Copy Link

why not args = "hc -root=. "

why not `args = "hc -root=. "`
李衍志523370910113 commented 2025-03-02 10:54:36 +08:00
Outdated
Review
Copy Link

resolved.

resolved.
+ f"{repo_conf.groups.time_period_hour[i]},"
)
# default value hardcoded
group_config = group_config + "=100:24"
group_config = group_config.removesuffix(",")
return [
jon-lee marked this conversation as resolved Outdated
张泊明518370910136 commented 2025-03-05 15:22:11 +08:00
Outdated
Review
Copy Link

do we need that default?

do we need that default?
李衍志523370910113 commented 2025-03-05 15:41:30 +08:00
Outdated
Review
Copy Link

what is the situation internally in JOJ3? I just added that blindly when I reached that stage. Overall I think 100 times per day should be a reasonable and safe default? considering that there may be group works and due date

what is the situation internally in JOJ3? I just added that blindly when I reached that stage. Overall I think 100 times per day should be a reasonable and safe default? considering that there may be group works and due date
张泊明518370910136 commented 2025-03-05 15:43:06 +08:00
Outdated
Review
Copy Link

They can manually add it if needed. Or just move it to the model default.

They can manually add it if needed. Or just move it to the model default.
李衍志523370910113 commented 2025-03-05 15:50:43 +08:00
Outdated
Review
Copy Link

removed.

removed.
"/usr/local/bin/joint-teapot",
"joj3-check-env",

2
tests/convert/basic/task.json
View File

@ -74,7 +74,7 @@
"--grading-repo-name",
"ece280-joj",
"--group-config",
"joj=1000:24,run=1000:24,=100:24"
"joj=1000:24,run=1000:24"
],
"env": [
"LOG_FILE_PATH=/home/tt/.cache/joint-teapot-debug.log"