JOJ/JOJ3-config-generator
27
1
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

dev #10

Merged
李衍志523370910113 merged 238 commits from dev into master 2025-03-05 16:20:39 +08:00
Conversation 16 Commits 238 Files Changed 42 +27
2 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9bd662df8c - Show all commits

26
joj3_config_generator/models/result.py
View File

@ -150,3 +150,29 @@ class Config(BaseModel):
actor_csv_path: str = Field("", serialization_alias="actorCsvPath")
max_total_score: int = Field(100, serialization_alias="maxTotalScore")
stage: Stage
class DummyConfig(BaseModel):
score: Optional[int] = None
comment: Optional[str] = None
force_quit_on_not_accepted: Optional[bool] = Field(
False, alias="forceQuitOnNotAccepted"
)
class DiffOutputConfig(BaseModel):
score: Optional[int] = None
file_name: str = Field("", alias="fileName")
answer_path: str = Field("", alias="answerPath")
force_quit_on_diff: Optional[bool] = Field(False, alias="forceQuitOnDiff")
always_hide: Optional[bool] = Field(False, alias="alwaysHide")
compare_space: Optional[bool] = Field(False, alias="compareSpace")
jon-lee marked this conversation as resolved Outdated
张泊明518370910136 commented 2025-03-05 10:43:07 +08:00
Outdated
Review
Copy Link

Are these Optional necessary?

Are these `Optional` necessary?
class ResultDetailConfig(BaseModel):
score: int = 0
comment: str = ""
show_files: List[str] = Field([], alias="showFiles")
show_exit_status: Optional[bool] = Field(True, alias="showExitStatus")
show_runtime: Optional[bool] = Field(True, alias="showRuntime")
show_memory: Optional[bool] = Field(False, alias="showMemory")
jon-lee marked this conversation as resolved
张泊明518370910136 commented 2025-03-05 11:40:52 +08:00
Review
Copy Link

also these Optional?

also these `Optional`?
李衍志523370910113 commented 2025-03-05 12:25:45 +08:00
Review
Copy Link

I guess some of the field have default within JOJ3, so I choose optional just to reduce the length of json previously

I guess some of the field have default within JOJ3, so I choose optional just to reduce the length of json previously
张泊明518370910136 commented 2025-03-05 12:28:00 +08:00
Review
Copy Link

better put all defaults here then we only need to check the code here

better put all defaults here then we only need to check the code here
李衍志523370910113 commented 2025-03-05 13:06:03 +08:00
Review
Copy Link

indeed.

indeed.

1
joj3_config_generator/processers/task.py
View File

@ -11,6 +11,7 @@ def get_conf_stage(
conf_stage = result.StageDetail(
name=task_stage.name if task_stage.name is not None else "",
# group is determined by adding between "[]" in the name of the task
# FIXME: this is probably outdated
group=(
match.group(1)
jon-lee marked this conversation as resolved Outdated
李衍志523370910113 commented 2025-03-03 11:12:45 +08:00
Outdated
Review
Copy Link

BTW, is this outdated?

BTW, is this outdated?
张泊明518370910136 commented 2025-03-03 11:17:54 +08:00
Outdated
Review
Copy Link

Never heard about this rule.

Never heard about this rule.
李衍志523370910113 commented 2025-03-03 11:19:19 +08:00
Outdated
Review
Copy Link

@manuel what would be the current intended rule for group?

@manuel what would be the current intended rule for `group`?
李衍志523370910113 commented 2025-03-03 16:18:13 +08:00
Outdated
Review
Copy Link

seems current strategy is fine, resolved.

seems current strategy is fine, resolved.
if (match := re.search(r"\[([^\[\]]+)\]", task_stage.name or ""))