JOJ/JOJ3-config-generator
27
1
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

dev #10

Merged
李衍志523370910113 merged 238 commits from dev into master 2025-03-05 16:20:39 +08:00
Conversation 16 Commits 238 Files Changed 42 -1
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9f4eda337b - Show all commits

1
joj3_config_generator/models/result.py
View File

@ -210,7 +210,6 @@ class DiffCasesConfig(BaseModel):
outputs: List[DiffOutputConfig] = []
# to get minimum flexibility, may refine in future
class DiffConfig(BaseModel):
jon-lee marked this conversation as resolved
张泊明518370910136 commented 2025-03-05 15:49:07 +08:00
Review
Copy Link

what needs to be refined?

what needs to be refined?
李衍志523370910113 commented 2025-03-05 15:52:55 +08:00
Review
Copy Link

just feels bit waste since this outputs only have one field before I coded the logic, I wrote that comment without checking the details of diff parser. But it should be the best strategy to show the structures as well as give flexiblity for extension now.

just feels bit waste since this outputs only have one field before I coded the logic, I wrote that comment without checking the details of diff parser. But it should be the best strategy to show the structures as well as give flexiblity for extension now.
name: str = "diff"
cases: List[DiffCasesConfig] = []