JOJ/JOJ3-config-generator
27
1
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(diff): bugs on diff stdin and numerics #16

Merged
张泊明518370910136 merged 22 commits from fix/diff into master 2025-05-24 02:45:39 +08:00
Conversation 1 Commits 22 Files Changed 9 +4 -20
3 changed files with 4 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7265411abe - Show all commits

7
joj3_config_generator/transformers/task.py
View File

@ -13,6 +13,7 @@ from joj3_config_generator.models.const import (
JOJ3_CONFIG_ROOT,
)
from joj3_config_generator.models.task import Parser as ParserEnum
from joj3_config_generator.utils.logger import logger
def get_conf_stage(
@ -255,12 +256,12 @@ def get_testcases(
) -> Set[str]: # basedir here should be task_conf.root / task_conf.path
testcases = set()
for testcases_path in (task_root / task_path).parent.glob("**/*.in"):
if not os.path.exists(str(testcases_path).removesuffix(".in") + ".out"):
jon-lee marked this conversation as resolved
张泊明518370910136 commented 2025-05-23 20:42:10 +08:00
Review
Copy Link

if not testcases_path.with_suffix(".out").exists():

`if not testcases_path.with_suffix(".out").exists():`
李衍志523370910113 commented 2025-05-23 20:57:21 +08:00
Review
Copy Link

done

done
logger.warning(f"Testcase {testcases_path} has no corresponding .out file")
continue
testcases.add(
str(
jon-lee marked this conversation as resolved Outdated
张泊明518370910136 commented 2025-05-23 20:30:58 +08:00
Outdated
Review
Copy Link

No. Just do not append it to the return value and log a warning.

No. Just do not append it to the return value and log a warning.
李衍志523370910113 commented 2025-05-23 20:40:57 +08:00
Outdated
Review
Copy Link

we can probably move some redundant functions like get_testcaes into a utils.py as file llines already bit large

we can probably move some redundant functions like `get_testcaes` into a `utils.py` as file llines already bit large
张泊明518370910136 commented 2025-05-23 20:43:59 +08:00
Outdated
Review
Copy Link

leave it here now. we have not reused the logic.

leave it here now. we have not reused the logic.
👍 1
testcases_path.relative_to((task_root / task_path).parent)
).removesuffix(".in")
)
assert os.path.exists(
str(testcases_path).removesuffix(".in") + ".out"
), f"{testcases_path} does not have a corresponding *.out file!"
return testcases

0
tests/convert/diff/case3.out
View File

17
tests/convert/diff/task.json
View File

@ -111,11 +111,6 @@
"src": "/home/tt/.config/joj/diff/case2.in"
}
},
{
"stdin": {
"src": "/home/tt/.config/joj/diff/case3.in"
}
},
{
"stdin": {
"src": "/home/tt/.config/joj/diff/task1/case4.in"
@ -229,18 +224,6 @@
}
]
},
{
"outputs": [
{
"score": 100,
"fileName": "stdout",
"answerPath": "/home/tt/.config/joj/diff/case3.out",
"forceQuitOnDiff": false,
"alwaysHide": false,
"compareSpace": false
}
]
},
{
"outputs": [
{