JOJ/JOJ3
25
6
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(healthcheck/nonasciifile): comment, code style and check range
Some checks failed
build / build (push) Failing after 1m18s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Failing after 1m17s
Details
build / trigger-build-image (pull_request) Has been skipped
Details

Browse Source
This commit is contained in:
zzjc1234 2024-10-21 16:21:12 +08:00
parent 373d31cb5c
commit 68e4c8e01e
2 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/repo-health-checker/main.go
View File

@ -43,12 +43,12 @@ func main() {
showVersion := flag.Bool("version", false, "print current version") showVersion := flag.Bool("version", false, "print current version")
rootDir := flag.String("root", ".", "root dir for forbidden files check") rootDir := flag.String("root", ".", "root dir for forbidden files check")
repoSize := flag.Float64("repoSize", 2, "maximum size of the repo in MiB") repoSize := flag.Float64("repoSize", 2, "maximum size of the repo in MiB")
// TODO: remove gitWhitelist, it is only for backward compatibility now // TODO: remove git whitelist, it is only for backward compatibility now
localList := flag.String("localList", "", "local file list for non-ascii file check") localList := flag.String("localList", "", "local file list for non-ascii file check")
checkFileNameList := flag.String("checkFileNameList", "", "comma-separated list of files to check") checkFileNameList := flag.String("checkFileNameList", "", "comma-separated list of files to check")
checkFileSumList := flag.String("checkFileSumList", "", "comma-separated list of expected checksums") checkFileSumList := flag.String("checkFileSumList", "", "comma-separated list of expected checksums")
parseMultiValueFlag(&metaFile, "meta", "meta files to check") parseMultiValueFlag(&metaFile, "meta", "meta files to check")
// TODO: remove gitWhitelist, it is only for backward compatibility now // TODO: remove git whitelist, it is only for backward compatibility now
var gitWhitelist []string var gitWhitelist []string
parseMultiValueFlag(&gitWhitelist, "whitelist", "[DEPRECATED] will be ignored") parseMultiValueFlag(&gitWhitelist, "whitelist", "[DEPRECATED] will be ignored")
flag.Parse() flag.Parse()

18
pkg/healthcheck/nonascii.go
View File

@ -16,14 +16,14 @@ import (
// It searches for non-ASCII characters in each file's content and returns a list of paths to files containing non-ASCII characters. // It searches for non-ASCII characters in each file's content and returns a list of paths to files containing non-ASCII characters.
func getNonAscii(root string) ([]string, error) { func getNonAscii(root string) ([]string, error) {
var nonAscii []string var nonAscii []string
noAttri := false gitattrExist := true
var matcher gitattributes.Matcher var matcher gitattributes.Matcher
_, err := os.Stat(".gitattributes") _, err := os.Stat(".gitattributes")
if os.IsNotExist(err) { if os.IsNotExist(err) {
noAttri = true gitattrExist = false
} }
if !noAttri { if gitattrExist {
fs := os.DirFS(".") fs := os.DirFS(".")
f, err := fs.Open(".gitattributes") f, err := fs.Open(".gitattributes")
if err != nil { if err != nil {
@ -43,25 +43,19 @@ func getNonAscii(root string) ([]string, error) {
} }
if info.IsDir() { if info.IsDir() {
if info.Name() == ".git" || info.Name() == ".gitea" { if info.Name() == ".git" {
return filepath.SkipDir return filepath.SkipDir
} else { } else {
return nil return nil
} }
} }
if info.Name() == "healthcheck" { if gitattrExist {
return nil
}
if !noAttri {
relPath, err := filepath.Rel(root, path) relPath, err := filepath.Rel(root, path)
if err != nil { if err != nil {
return err return err
} }
str := strings.Split(relPath, "/") if _, ret := matcher.Match(strings.Split(relPath, "/"), nil); ret {
_, ret := matcher.Match(str, nil)
if ret {
return nil return nil
} }
} }