From d76fe99811a81cb2635fca283afd920e6fbe64f2 Mon Sep 17 00:00:00 2001
From: Boming Zhang <bomingzh@sjtu.edu.cn>
Date: Fri, 4 Oct 2024 09:22:23 -0400
Subject: [PATCH] feat: return error on Atoi failed

---
 internal/parsers/clangtidy/convert.go | 13 +++++++++++--
 internal/parsers/cpplint/parser.go    | 19 +++++++++++++++++--
 2 files changed, 28 insertions(+), 4 deletions(-)

diff --git a/internal/parsers/clangtidy/convert.go b/internal/parsers/clangtidy/convert.go
index ea5aa1f..88e87e3 100644
--- a/internal/parsers/clangtidy/convert.go
+++ b/internal/parsers/clangtidy/convert.go
@@ -2,6 +2,7 @@
 package clangtidy
 
 import (
+	"log/slog"
 	"path/filepath"
 	"regexp"
 	"strconv"
@@ -78,8 +79,16 @@ func parseMessage(line string) ClangMessage {
 		return *newClangMessage("", 0, 0, UNKNOWN, "", "", nil, nil)
 	} else {
 		filepath := regexRes[1]
-		line, _ := strconv.Atoi(regexRes[2])
-		column, _ := strconv.Atoi(regexRes[3])
+		line, err := strconv.Atoi(regexRes[2])
+		if err != nil {
+			line = 0
+			slog.Error("parse line", "error", err)
+		}
+		column, err := strconv.Atoi(regexRes[3])
+		if err != nil {
+			column = 0
+			slog.Error("parse column", "error", err)
+		}
 		level := levelFromString(regexRes[4])
 		message := regexRes[5]
 		diagnosticName := regexRes[6]
diff --git a/internal/parsers/cpplint/parser.go b/internal/parsers/cpplint/parser.go
index 881ea54..9d83e42 100644
--- a/internal/parsers/cpplint/parser.go
+++ b/internal/parsers/cpplint/parser.go
@@ -2,6 +2,7 @@ package cpplint
 
 import (
 	"fmt"
+	"log/slog"
 	"regexp"
 	"strconv"
 
@@ -23,10 +24,24 @@ func Parse(executorResult stage.ExecutorResult, conf Conf) stage.ParserResult {
 	comment := ""
 	for _, match := range matches {
 		fileName := match[1]
-		lineNum, _ := strconv.Atoi(match[2])
+		lineNum, err := strconv.Atoi(match[2])
+		if err != nil {
+			slog.Error("parse lineNum", "error", err)
+			return stage.ParserResult{
+				Score:   0,
+				Comment: fmt.Sprintf("Unexpected parser error: %s.", err),
+			}
+		}
 		message := match[3]
 		category := match[4]
-		confidence, _ := strconv.Atoi(match[5])
+		confidence, err := strconv.Atoi(match[5])
+		if err != nil {
+			slog.Error("parse confidence", "error", err)
+			return stage.ParserResult{
+				Score:   0,
+				Comment: fmt.Sprintf("Unexpected parser error: %s.", err),
+			}
+		}
 		score -= confidence
 		// TODO: add more detailed comment, just re-assemble for now
 		comment += fmt.Sprintf("%s:%d:  %s  [%s] [%d]\n",