clangtidy parser #18

New Issue

张佳澈520370910044 · 2024-03-29T09:47:40+08:00

张佳澈520370910044 commented

2024-03-29 09:47:40 +08:00

https://github.com/yuriisk/clang-tidy-converter/blob/master/clang_tidy_converter/parser/clang_tidy_parser.py

张佳澈520370910044 added the

labels 2024-03-29 09:47:40 +08:00

张佳澈520370910044 self-assigned this 2024-03-29 09:47:41 +08:00

张佳澈520370910044 added this to the (deleted) project 2024-03-29 09:47:41 +08:00

张泊明518370910136 changed title from ~~clang-tudy executor and parser~~ to clang-tidy executor and parser

2024-03-29 15:16:03 +08:00

张泊明518370910136 changed title from ~~clang-tidy executor and parser~~ to clang-tidy parser

2024-03-31 13:39:31 +08:00

张佳澈520370910044 commented

2024-04-20 22:06:47 +08:00

Do we need a detailed report on every single warning, or just give the total number of warnings and generate a final score?

manuel commented

2024-04-20 23:05:36 +08:00

the config file will contain a list of warning to catch. we should show the list such that they know where the issue is.

-> you can check what we did in 482 last fall (what the report looks like)

the config file will contain a list of warning to catch. we should show the list such that they know where the issue is. -> you can check what we did in 482 last fall (what the report looks like)

张佳澈520370910044 commented

2024-04-21 17:01:30 +08:00

I think they are all deleted... I can't access drone anymore

I can only see reports in issues, which only includes the summary of warning counts instead of details

I think I still remember a little bit, not a big issue

I think they are all deleted... I can't access drone anymore I can only see reports in issues, which only includes the summary of warning counts instead of details I think I still remember a little bit, not a big issue

manuel commented

2024-04-22 17:40:56 +08:00

go to 482 repos, find an issue and click on one of the links, eg. https://focs.ji.sjtu.edu.cn:2222/ece482-23fa/ChihusanChen521370910128-p1/44/1/6

repos not listed on drone because they have been archived (guessing)

go to 482 repos, find an issue and click on one of the links, eg. https://focs.ji.sjtu.edu.cn:2222/ece482-23fa/ChihusanChen521370910128-p1/44/1/6 repos not listed on drone because they have been archived (guessing)

张佳澈520370910044 commented

2024-04-25 22:48:13 +08:00

I get 404 error by clicking this link (and all other links in archived repos)

We are sorry, the resource you requested cannot be found.That's all we know.

I get 404 error by clicking this link (and all other links in archived repos) > We are sorry, the resource you requested cannot be found.That's all we know.

manuel commented

2024-04-25 22:53:00 +08:00

maybe drone cannot see that you re logged in. try to connect "manually" before clicking the link

张佳澈520370910044 commented

2024-04-25 23:04:41 +08:00

What do you mean by connect "manually"?

I tried re-logging in both gitea and drone and it remained the same

Are you possibly referring to connect "manuelly" (as the admin so you can see everything🤣)

What do you mean by connect "manually"? I tried re-logging in both gitea and drone and it remained the same Are you possibly referring to connect "manuelly" (as the admin so you can see everything🤣)

manuel commented

2024-04-26 11:21:53 +08:00

@zjc_he not sure... if you have itme you can come to my 214 exam between 12pm and 1:40pm. we can check it...

张佳澈520370910044 commented

2024-04-26 13:47:23 +08:00

I'm in Beijing now and I'm not back in Shanghai until Summer semester😥

Maybe we can check it in 475 class

I'm in Beijing now and I'm not back in Shanghai until Summer semester😥 Maybe we can check it in 475 class

manuel commented

2024-04-28 11:41:17 +08:00

sample output:

Compilation

This part of the report provide basic information on the compilation success or failure. For more details refer to https://focs.ji.sjtu.edu.cn:2222/ece482-23fa/ChihusanChen521370910128-p1/26/1/4

Compilation report

Command line

clang-16 *.c -std=gnu17 -Wvla -Wall -Wextra -Werror -Wpedantic -Wno-unused-result -Wconversion

Congratulations, all files compiled without any error!

Code quality

This part of the report lists how many errors were found for each code quality test. For more details refer to https://focs.ji.sjtu.edu.cn:2222/ece482-23fa/ChihusanChen521370910128-p1/26/1/5

filelength report

Test command line

filelength *.c

Test results summary

filesize: 0

clang-tidy report

Test command line

clang-tidy --header-filter=.* --quiet --load=/usr/local/lib/libcodequality.so *.c *.h

Test results summary

codequality-unchecked-malloc-result: 0
codequality-no-global-variables: 3
codequality-no-header-guard: 0
codequality-no-fflush-stdin: 0
readability-function-size: 0
readability-duplicate-include: 0
readability-identifier-naming: 0
readability-redundant: 0
readability-misleading-indentation: 0
readability-misplaced-array-index: 0
cppcoreguidelines-init-variables: 3
bugprone-suspicious-string-compare: 0
google-global-names-in-headers: 0
clang-diagnostic: 3
clang-analyzer: 0
misc: 0
performance: 0

cppcheck report

Test command line

cppcheck --enable=all ./

Test results summary

error: 2
warning: 0
portability: 0
performance: 0
style: 2

cpplint report

Test command line

cpplint --linelength=120 --filter=-legal,-readability/casting,-whitespace,-runtime/printf,-runtime/threadsafe_fn,-readability/todo,-build/include_subdir,-build/header_guard *.h *.c

Test results summary

runtime: 0
readability: 8
build: 0

JOJ results for p1m3-0 problems 1 2 3 4 5 6

This part of the report shows the results for the requested JOJ tests.

JOJ problem 1

Summary

p1m3-0.tar.gz upload succeed, record url https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d
status: Wrong Answer, accept number: 1, score: 10, total time: 91 ms, peak memory: 1.969 MiB

Details

JOJ problem 2

Summary

p1m3-0.tar.gz upload succeed, record url https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510
status: Wrong Answer, accept number: 1, score: 10, total time: 867 ms, peak memory: 8.363 MiB

Details

JOJ problem 3

Summary

p1m3-0.tar.gz upload succeed, record url https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513
status: Wrong Answer, accept number: 2, score: 20, total time: 178 ms, peak memory: 5.809 MiB

Details

JOJ problem 4

Summary

p1m3-0.tar.gz upload succeed, record url https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516
status: Wrong Answer, accept number: 2, score: 20, total time: 407 ms, peak memory: 8.52 MiB

Details

JOJ problem 5

Summary

p1m3-0.tar.gz upload succeed, record url https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347a40124c3000639c519
status: Wrong Answer, accept number: 0, score: 0, total time: 24 ms, peak memory: 2.207 MiB

Details

JOJ problem 6

Summary

p1m3-0.tar.gz upload succeed, record url https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347aa0124c3000639c51c
status: Wrong Answer, accept number: 0, score: 0, total time: 197 ms, peak memory: 7.445 MiB

Details

@mac

sample output: ![cq_Score](https://img.shields.io/badge/Code_Quality-94%25-green) ![joj_Score](https://img.shields.io/badge/JOJ_p1m3--0-7%25-red) # Compilation This part of the report provide basic information on the compilation success or failure. For more details refer to https://focs.ji.sjtu.edu.cn:2222/ece482-23fa/ChihusanChen521370910128-p1/26/1/4 ## Compilation report ### Command line ``` clang-16 *.c -std=gnu17 -Wvla -Wall -Wextra -Werror -Wpedantic -Wno-unused-result -Wconversion ``` Congratulations, all files compiled without any error! # Code quality This part of the report lists how many errors were found for each code quality test. For more details refer to https://focs.ji.sjtu.edu.cn:2222/ece482-23fa/ChihusanChen521370910128-p1/26/1/5 ## filelength report ### Test command line ``` filelength *.c ``` ### Test results summary 1. filesize: 0 ## clang-tidy report ### Test command line ``` clang-tidy --header-filter=.* --quiet --load=/usr/local/lib/libcodequality.so *.c *.h ``` ### Test results summary 1. codequality-unchecked-malloc-result: 0 2. codequality-no-global-variables: 3 3. codequality-no-header-guard: 0 4. codequality-no-fflush-stdin: 0 5. readability-function-size: 0 6. readability-duplicate-include: 0 7. readability-identifier-naming: 0 8. readability-redundant: 0 9. readability-misleading-indentation: 0 10. readability-misplaced-array-index: 0 11. cppcoreguidelines-init-variables: 3 12. bugprone-suspicious-string-compare: 0 13. google-global-names-in-headers: 0 14. clang-diagnostic: 3 15. clang-analyzer: 0 16. misc: 0 17. performance: 0 ## cppcheck report ### Test command line ``` cppcheck --enable=all ./ ``` ### Test results summary 1. error: 2 2. warning: 0 3. portability: 0 4. performance: 0 5. style: 2 ## cpplint report ### Test command line ``` cpplint --linelength=120 --filter=-legal,-readability/casting,-whitespace,-runtime/printf,-runtime/threadsafe_fn,-readability/todo,-build/include_subdir,-build/header_guard *.h *.c ``` ### Test results summary 1. runtime: 0 2. readability: 8 3. build: 0 # JOJ results for p1m3-0 problems 1 2 3 4 5 6 This part of the report shows the results for the requested JOJ tests. ## JOJ problem 1 ### Summary p1m3-0.tar.gz upload succeed, record url https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d status: Wrong Answer, accept number: 1, score: 10, total time: 91 ms, peak memory: 1.969 MiB ### Details 1. [Accepted, time: 2 ms, memory: 748.0 KiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/1) 2. [Wrong Answer, time: 3 ms, memory: 936.0 KiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/2) 3. [Wrong Answer, time: 2 ms, memory: 1.125 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/3) 4. [Wrong Answer, time: 4 ms, memory: 1.355 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/4) 5. [Wrong Answer, time: 2 ms, memory: 1.09 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/5) 6. [Wrong Answer, time: 2 ms, memory: 1.332 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/6) 7. [Wrong Answer, time: 6 ms, memory: 1.594 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/7) 8. [Wrong Answer, time: 4 ms, memory: 1.543 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/8) 9. [Wrong Answer, time: 3 ms, memory: 1.57 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/9) 10. [Wrong Answer, time: 5 ms, memory: 1.734 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/10) 11. [Wrong Answer, time: 3 ms, memory: 1.492 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/11) 12. [Wrong Answer, time: 4 ms, memory: 1.652 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/12) 13. [Wrong Answer, time: 6 ms, memory: 1.789 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/13) 14. [Wrong Answer, time: 5 ms, memory: 1.969 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/14) 15. [Wrong Answer, time: 8 ms, memory: 1.789 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/15) 16. [Wrong Answer, time: 8 ms, memory: 1.875 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/16) 17. [Wrong Answer, time: 9 ms, memory: 1.855 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/17) 18. [Wrong Answer, time: 7 ms, memory: 1.965 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523477c0124c3000639c50d/cases/18) ## JOJ problem 2 ### Summary p1m3-0.tar.gz upload succeed, record url https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510 status: Wrong Answer, accept number: 1, score: 10, total time: 867 ms, peak memory: 8.363 MiB ### Details 1. [Accepted, time: 10 ms, memory: 4.434 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/1) 2. [Wrong Answer, time: 19 ms, memory: 6.875 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/2) 3. [Wrong Answer, time: 19 ms, memory: 6.629 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/3) 4. [Wrong Answer, time: 35 ms, memory: 7.34 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/4) 5. [Wrong Answer, time: 18 ms, memory: 6.75 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/5) 6. [Wrong Answer, time: 18 ms, memory: 6.906 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/6) 7. [Wrong Answer, time: 52 ms, memory: 7.832 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/7) 8. [Wrong Answer, time: 67 ms, memory: 7.516 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/8) 9. [Wrong Answer, time: 35 ms, memory: 7.25 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/9) 10. [Wrong Answer, time: 58 ms, memory: 7.488 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/10) 11. [Wrong Answer, time: 36 ms, memory: 7.297 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/11) 12. [Wrong Answer, time: 45 ms, memory: 7.785 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/12) 13. [Wrong Answer, time: 54 ms, memory: 7.613 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/13) 14. [Wrong Answer, time: 52 ms, memory: 7.781 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/14) 15. [Wrong Answer, time: 85 ms, memory: 8.156 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/15) 16. [Wrong Answer, time: 85 ms, memory: 7.844 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/16) 17. [Wrong Answer, time: 85 ms, memory: 8.242 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/17) 18. [Wrong Answer, time: 85 ms, memory: 8.363 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347890124c3000639c510/cases/18) ## JOJ problem 3 ### Summary p1m3-0.tar.gz upload succeed, record url https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513 status: Wrong Answer, accept number: 2, score: 20, total time: 178 ms, peak memory: 5.809 MiB ### Details 1. [Wrong Answer, time: 4 ms, memory: 2.156 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513/cases/1) 2. [Wrong Answer, time: 3 ms, memory: 2.113 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513/cases/2) 3. [Wrong Answer, time: 3 ms, memory: 2.066 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513/cases/3) 4. [Wrong Answer, time: 3 ms, memory: 2.117 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513/cases/4) 5. [Wrong Answer, time: 2 ms, memory: 1.113 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513/cases/5) 6. [Accepted, time: 1 ms, memory: 552.0 KiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513/cases/6) 7. [Wrong Answer, time: 2 ms, memory: 1.348 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513/cases/7) 8. [Wrong Answer, time: 6 ms, memory: 2.086 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513/cases/8) 9. [Wrong Answer, time: 3 ms, memory: 1.621 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513/cases/9) 10. [Wrong Answer, time: 5 ms, memory: 2.336 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513/cases/10) 11. [Wrong Answer, time: 125 ms, memory: 5.809 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513/cases/11) 12. [Accepted, time: 17 ms, memory: 2.711 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347960124c3000639c513/cases/12) ## JOJ problem 4 ### Summary p1m3-0.tar.gz upload succeed, record url https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516 status: Wrong Answer, accept number: 2, score: 20, total time: 407 ms, peak memory: 8.52 MiB ### Details 1. [Wrong Answer, time: 28 ms, memory: 7.172 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516/cases/1) 2. [Wrong Answer, time: 15 ms, memory: 7.027 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516/cases/2) 3. [Wrong Answer, time: 16 ms, memory: 7.121 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516/cases/3) 4. [Wrong Answer, time: 15 ms, memory: 7.324 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516/cases/4) 5. [Wrong Answer, time: 23 ms, memory: 6.887 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516/cases/5) 6. [Accepted, time: 10 ms, memory: 4.383 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516/cases/6) 7. [Wrong Answer, time: 19 ms, memory: 6.801 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516/cases/7) 8. [Wrong Answer, time: 73 ms, memory: 7.984 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516/cases/8) 9. [Wrong Answer, time: 35 ms, memory: 7.148 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516/cases/9) 10. [Wrong Answer, time: 19 ms, memory: 7.34 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516/cases/10) 11. [Wrong Answer, time: 105 ms, memory: 8.52 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516/cases/11) 12. [Accepted, time: 45 ms, memory: 6.652 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/6523479d0124c3000639c516/cases/12) ## JOJ problem 5 ### Summary p1m3-0.tar.gz upload succeed, record url https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347a40124c3000639c519 status: Wrong Answer, accept number: 0, score: 0, total time: 24 ms, peak memory: 2.207 MiB ### Details 1. [Wrong Answer, time: 3 ms, memory: 2.207 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347a40124c3000639c519/cases/1) 2. [Wrong Answer, time: 2 ms, memory: 1.234 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347a40124c3000639c519/cases/2) 3. [Wrong Answer, time: 2 ms, memory: 1.336 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347a40124c3000639c519/cases/3) 4. [Wrong Answer, time: 4 ms, memory: 1.859 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347a40124c3000639c519/cases/4) 5. [Wrong Answer, time: 3 ms, memory: 1.434 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347a40124c3000639c519/cases/5) 6. [Wrong Answer, time: 3 ms, memory: 1.297 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347a40124c3000639c519/cases/6) 7. [Wrong Answer, time: 2 ms, memory: 1.141 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347a40124c3000639c519/cases/7) 8. [Wrong Answer, time: 1 ms, memory: 676.0 KiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347a40124c3000639c519/cases/8) ## JOJ problem 6 ### Summary p1m3-0.tar.gz upload succeed, record url https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347aa0124c3000639c51c status: Wrong Answer, accept number: 0, score: 0, total time: 197 ms, peak memory: 7.445 MiB ### Details 1. [Wrong Answer, time: 23 ms, memory: 7.406 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347aa0124c3000639c51c/cases/1) 2. [Wrong Answer, time: 34 ms, memory: 6.504 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347aa0124c3000639c51c/cases/2) 3. [Wrong Answer, time: 18 ms, memory: 6.785 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347aa0124c3000639c51c/cases/3) 4. [Wrong Answer, time: 36 ms, memory: 7.445 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347aa0124c3000639c51c/cases/4) 5. [Wrong Answer, time: 24 ms, memory: 6.941 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347aa0124c3000639c51c/cases/5) 6. [Wrong Answer, time: 29 ms, memory: 6.676 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347aa0124c3000639c51c/cases/6) 7. [Wrong Answer, time: 19 ms, memory: 7.0 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347aa0124c3000639c51c/cases/7) 8. [Wrong Answer, time: 10 ms, memory: 4.504 MiB](https://joj.sjtu.edu.cn/d/ece482_23fa/records/652347aa0124c3000639c51c/cases/8) @mac

张佳澈520370910044 commented

2024-04-30 21:56:34 +08:00

internal/parsers/clang_tidy/formatter.go:5:2: G501: Blocklisted import crypto/md5: weak cryptographic primitive (gosec)
        "crypto/md5"
        ^
internal/parsers/clang_tidy/formatter.go:191:7: G401: Use of weak cryptographic primitive (gosec)
        h := md5.New()

Gosec forbids me from using md5... It says md5 is weak 😅 However thats what was used by GitLab code quality report.

I think this is unimportant, maybe we don't need it? I can just delete this value

``` internal/parsers/clang_tidy/formatter.go:5:2: G501: Blocklisted import crypto/md5: weak cryptographic primitive (gosec) "crypto/md5" ^ internal/parsers/clang_tidy/formatter.go:191:7: G401: Use of weak cryptographic primitive (gosec) h := md5.New() ``` Gosec forbids me from using md5... It says md5 is weak 😅 However thats what was used by GitLab code quality report. I think this is unimportant, maybe we don't need it? I can just delete this value

张佳澈520370910044 commented

2024-04-30 21:57:47 +08:00

{
    "type": "issue",
    "check_name": "readability-identifier-length",
    "description": "variable name 'b' is too short, expected at least 3 characters",
    "content": {
      "body": "```\n```"
    },
    "categories": [
      "Clarity"
    ],
    "location": {
      "path": "a.cc",
      "lines": {
        "begin": 3
      }
    },
    "trace": {
      "locations": []
    },
    "severity": "major",
    "fingerprint": "17728eaba21c9cb70e9ea5074ff22666"
  }

I'm referring to the "fingerprint" above

``` { "type": "issue", "check_name": "readability-identifier-length", "description": "variable name 'b' is too short, expected at least 3 characters", "content": { "body": "```\n```" }, "categories": [ "Clarity" ], "location": { "path": "a.cc", "lines": { "begin": 3 } }, "trace": { "locations": [] }, "severity": "major", "fingerprint": "17728eaba21c9cb70e9ea5074ff22666" } ``` I'm referring to the "fingerprint" above

manuel commented

2024-04-30 22:08:05 +08:00

md5 has indeed been broken for ~15 years. it should not be used. neither should sha1.
options: sha3 or sha256. more on that in ece475 😉

md5 has indeed been broken for ~15 years. it should not be used. neither should sha1. options: sha3 or sha256. more on that in ece475 😉

张佳澈520370910044 commented

2024-05-01 00:29:00 +08:00

I'm leaving this blank for now. If needed I may rewrite in the future(but I think we do not need this)

张佳澈520370910044 changed title from ~~clang-tidy parser~~ to clangtidy parser

2024-05-18 08:48:12 +08:00

张佳澈520370910044 commented

2024-05-18 08:48:26 +08:00

Completed in #26