feat: diff parser #33

张泊明518370910136 · 2024-09-09T03:10:19+08:00

张泊明518370910136 commented

2024-09-09 03:10:19 +08:00

No description provided.

周赵嘉程521432910016 was assigned by 张泊明518370910136

2024-09-09 03:24:26 +08:00

张泊明518370910136 commented

2024-09-09 03:24:41 +08:00

@zzjc123 You need to rebase the branch on master instead of healthcheck so that I can start reviewing the code.

The diff parser needs a character-by-character comparison algorithm so that we can choose whether to ignore whitespace or not as not all the problems requires the output format to be exactly the same.

You can check https://cs.opensource.google/go/x/tools/+/refs/tags/v0.1.12:internal/lsp/diff/myers/diff.go and https://github.com/cj1128/myers-diff/blob/master/main.go.

@zzjc123 You need to rebase the branch on master instead of healthcheck so that I can start reviewing the code. The diff parser needs a character-by-character comparison algorithm so that we can choose whether to ignore whitespace or not as not all the problems requires the output format to be exactly the same. You can check https://cs.opensource.google/go/x/tools/+/refs/tags/v0.1.12:internal/lsp/diff/myers/diff.go and https://github.com/cj1128/myers-diff/blob/master/main.go.

周赵嘉程521432910016 force-pushed diff from 0af0994b8c to d47e14612a

2024-09-09 12:32:19 +08:00

Compare

周赵嘉程521432910016 commented

2024-09-09 14:41:23 +08:00

You mean we need to compare it by character but we still output like

-This is a test case.
-Hello, world
+This is a bad case.
+Hello, Hello
 test 12 asdf
+test 13 asdf

You mean we need to compare it by character but we still output like ```diff -This is a test case. -Hello, world +This is a bad case. +Hello, Hello test 12 asdf +test 13 asdf ```

周赵嘉程521432910016 commented

2024-09-09 14:47:25 +08:00

Could you give me a demo output for handling whitespace, didn't get you clearly. Which kind of cases we may face due to whitespace?

张泊明518370910136 commented

2024-09-10 15:52:53 +08:00

For some cases, if the answer is 123 456 789, we should also accept 123 456 789 and 1234 56 789. The output comment is just for assistance, no need to make it precise. Just show them in which line characters are different is enough.

For some cases, if the answer is `123 456 789`, we should also accept `123 456 789` and `1234 56 789`. The output comment is just for assistance, no need to make it precise. Just show them in which line characters are different is enough.

周赵嘉程521432910016 commented

2024-09-10 15:54:39 +08:00

Can we just pass an argument to ignore all whitespace? Or we cheat space tab as the same?