JOJ/JOJ3
24
5
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: repo health check (#16) #17

Merged
张泊明518370910136 merged 37 commits from file_check into master 2024-09-11 20:09:27 +08:00
Conversation 20 Commits 37 Files Changed 22 +7 -7
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2838f4171f - Show all commits

2
cmd/healthcheck/main.go
View File

@ -73,7 +73,7 @@ func main() {
fmt.Printf("## Non-ASCII Characters Commit Message Check Failed:\n%s\n", err.Error()) fmt.Printf("## Non-ASCII Characters Commit Message Check Failed:\n%s\n", err.Error())
} }
// TODO: find a way to test the release tag // TODO: find a way to test the release tag
bomingzh marked this conversation as resolved Outdated
张泊明518370910136 commented 2024-06-21 04:52:06 +08:00
Outdated
Review
Copy Link

check releases need to use Gitea API, just check tags is enough

check releases need to use Gitea API, just check tags is enough
汪睿522370910169 commented 2024-06-21 12:45:17 +08:00
Outdated
Review
Copy Link

Yep, only check tags

Yep, only check tags
张泊明518370910136 commented 2024-09-10 16:10:49 +08:00
Outdated
Review
Copy Link

Where is it tested?

Where is it tested?
err = healthcheck.CheckReleases(*rootDir, *releaseCategories, *releaseNumber) err = healthcheck.CheckTags(*rootDir, *releaseCategories, *releaseNumber)
if err != nil { if err != nil {
fmt.Printf("## Release Tag Check Failed:\n%s\n", err.Error()) fmt.Printf("## Release Tag Check Failed:\n%s\n", err.Error())
} }

7
pkg/healthcheck/forbidden.go
View File

@ -54,13 +54,14 @@ func getForbiddens(root string, fileList []string, localList string) ([]string,
} }
if info.IsDir() { if info.IsDir() {
if info.Name() == ".git" || info.Name() == ".gitea" || info.Name() == "ci" { switch {
case info.Name() == ".git" || info.Name() == ".gitea" || info.Name() == "ci":
return filepath.SkipDir return filepath.SkipDir
} else if localList != "" { case localList != "":
if inString(info.Name(), dirs) { if inString(info.Name(), dirs) {
return filepath.SkipDir return filepath.SkipDir
} }
} else { default:
return nil return nil
} }
} }

5
pkg/healthcheck/release.go → pkg/healthcheck/tag.go
View File

@ -2,7 +2,6 @@ package healthcheck
import ( import (
"fmt" "fmt"
"strings"
"github.com/go-git/go-git/v5" "github.com/go-git/go-git/v5"
"github.com/go-git/go-git/v5/plumbing" "github.com/go-git/go-git/v5/plumbing"
@ -31,7 +30,7 @@ func getTagsFromRepo(repoPath string) ([]string, error) {
return tags, nil return tags, nil
} }
func CheckReleases(repoPath string, category string, n int) error { func CheckTags(repoPath string, category string, n int) error {
tags, err := getTagsFromRepo(repoPath) tags, err := getTagsFromRepo(repoPath)
if err != nil { if err != nil {
return fmt.Errorf("error getting tags: %v", err) return fmt.Errorf("error getting tags: %v", err)
@ -56,7 +55,7 @@ func CheckReleases(repoPath string, category string, n int) error {
} }
} }
if !found { if !found {
return fmt.Errorf("Wrong release tag '%s' or missing release tags. Please use one of '%s'.", target, strings.Join(tags, "', '")) return fmt.Errorf("Expected tag '%s' not found.", target)
} }
return nil return nil
} }