JOJ/JOJ3
25
6
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: repo health check (#16) #17

Merged
张泊明518370910136 merged 37 commits from file_check into master 2024-09-11 20:09:27 +08:00
Conversation 20 Commits 37 Files Changed 22 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8383c21b28 - Show all commits

2
pkg/healthcheck/release.go
View File

@ -56,7 +56,7 @@ func CheckReleases(repoPath string, category string, n int) error {
}
}
if !found {
return fmt.Errorf("Wrong release tag '%s'. Please use one of '%s'.", target, strings.Join(tags, "', '"))
return fmt.Errorf("Wrong release tag '%s' or missing release tags. Please use one of '%s'.", target, strings.Join(tags, "', '"))
张泊明518370910136 commented 2024-06-19 15:01:45 +08:00
Outdated
Review
Copy Link

Why is the target release tag wrong?

Why is the `target` release tag wrong?
汪睿522370910169 commented 2024-06-19 16:46:49 +08:00
Outdated
Review
Copy Link

I intended to mean release tag is missing or wrong.

I intended to mean release tag is missing or wrong.
汪睿522370910169 commented 2024-06-19 16:48:23 +08:00
Outdated
Review
Copy Link

Do we need to specify missing or wrong? I think only we need to inform students that their release is wrong.

Do we need to specify missing or wrong? I think only we need to inform students that their release is wrong.
张泊明518370910136 commented 2024-06-20 05:23:32 +08:00
Outdated
Review
Copy Link

Do we need to test if they submit extra tags?

Do we need to test if they submit extra tags?
汪睿522370910169 commented 2024-06-20 09:56:43 +08:00
Outdated
Review
Copy Link

I think extra is fine, as long as they don't miss any tags.

I think extra is fine, as long as they don't miss any tags.
张泊明518370910136 commented 2024-06-20 12:33:55 +08:00
Outdated
Review
Copy Link

Then just print the error on missing tags.

Then just print the error on missing tags.
}
return nil
}