JOJ/JOJ3
25
6
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: repo health check (#16) #17

Merged
张泊明518370910136 merged 37 commits from file_check into master 2024-09-11 20:09:27 +08:00
Conversation 20 Commits 37 Files Changed 22 +4 -6
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ac583504e5 - Show all commits

10
pkg/healthcheck/verify.go
View File

@ -37,13 +37,13 @@ func checkFileChecksum(rootDir, fileName, expectedChecksum string) (bool, string
} }
if actualChecksum == expectedChecksum { if actualChecksum == expectedChecksum {
return true, ""//fmt.Sprintf("Checksum for %s passed!", filePath) return true, "" // fmt.Sprintf("Checksum for %s passed!", filePath)
bomingzh marked this conversation as resolved Outdated
张泊明518370910136 commented 2024-09-10 16:13:36 +08:00
Outdated
Review
Copy Link

remove the comment

remove the comment
} else { } else {
return false, fmt.Sprintf("Checksum for %s failed. Expected %s, but got %s. Please revert your changes or contact the teaching team if you have a valid reason for adjusting them.", filePath, expectedChecksum, actualChecksum) return false, fmt.Sprintf("Checksum for %s failed. Expected %s, but got %s. Please revert your changes or contact the teaching team if you have a valid reason for adjusting them.", filePath, expectedChecksum, actualChecksum)
} }
} }
func VerifyFiles(rootDir string,checkFileNameList string, checkFileSumList string ) error { func VerifyFiles(rootDir string, checkFileNameList string, checkFileSumList string) error {
// Parse command-line arguments // Parse command-line arguments
bomingzh marked this conversation as resolved Outdated
张泊明518370910136 commented 2024-09-10 16:13:55 +08:00
Outdated
Review
Copy Link

ditto

ditto
// checkFileNameList := flag.String("checkFileNameList", "", "Comma-separated list of files to check.") // checkFileNameList := flag.String("checkFileNameList", "", "Comma-separated list of files to check.")
// checkFileSumList := flag.String("checkFileSumList", "", "Comma-separated list of expected checksums.") // checkFileSumList := flag.String("checkFileSumList", "", "Comma-separated list of expected checksums.")
@ -51,7 +51,7 @@ func VerifyFiles(rootDir string,checkFileNameList string, checkFileSumList strin
// flag.Parse() // flag.Parse()
// Process input file names and checksums // Process input file names and checksums
if len(checkFileNameList) == 0 { if len(checkFileNameList) == 0 {
return nil//fmt.Errorf("No checksum happened") return nil // fmt.Errorf("No checksum happened")
os.Exit(1) os.Exit(1)
bomingzh marked this conversation as resolved Outdated
张泊明518370910136 commented 2024-09-10 16:14:23 +08:00
Outdated
Review
Copy Link

remove it

remove it
} }
fileNames := strings.Split(checkFileNameList, ",") fileNames := strings.Split(checkFileNameList, ",")
@ -59,7 +59,6 @@ func VerifyFiles(rootDir string,checkFileNameList string, checkFileSumList strin
// Check if the number of files matches the number of checksums // Check if the number of files matches the number of checksums
if len(fileNames) != len(checkSums) { if len(fileNames) != len(checkSums) {
return fmt.Errorf("Error: The number of files and checksums do not match.") return fmt.Errorf("Error: The number of files and checksums do not match.")
os.Exit(1) os.Exit(1)
张泊明518370910136 commented 2024-09-10 16:14:27 +08:00
Outdated
Review
Copy Link

remove it

remove it
张泊明518370910136 commented 2024-09-11 05:25:27 +08:00
Outdated
Review
Copy Link

I mean remove the os.Exit(1), and also the one on line 55.

I mean remove the `os.Exit(1)`, and also the one on line 55.
@ -80,9 +79,8 @@ func VerifyFiles(rootDir string,checkFileNameList string, checkFileSumList strin
errorMessages = append(errorMessages, message) errorMessages = append(errorMessages, message)
} }
} }
fmt.Printf("test")
if allPassed { if allPassed {
return nil//fmt.Errorf("Congratulations! All checksums passed!") return nil // fmt.Errorf("Congratulations! All checksums passed!")
张泊明518370910136 commented 2024-09-10 16:14:46 +08:00
Outdated
Review
Copy Link

ditto

ditto
} else { } else {
return fmt.Errorf("Some checksums failed. Please review the errors below:") return fmt.Errorf("Some checksums failed. Please review the errors below:")
张泊明518370910136 commented 2024-09-10 16:15:03 +08:00
Outdated
Review
Copy Link

Why so many returns?

Why so many returns?
for _, msg := range errorMessages { for _, msg := range errorMessages {