JOJ/JOJ3
24
5
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

fix/forbidden (#58) #60

Merged
张泊明518370910136 merged 7 commits from fix/forbidden into master 2024-10-18 14:41:10 +08:00
Conversation 21 Commits 7 Files Changed 4 +6 -1
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 44e3feb5c6 - Show all commits

7
pkg/healthcheck/forbidden.go
View File

@ -16,7 +16,12 @@ func getForbiddens(root string) ([]string, error) {
var matches []string var matches []string
// Create a gitignore instance from the .gitignore file // Create a gitignore instance from the .gitignore file
ignore, err := gitignore.NewFromFile(filepath.Join(root, ".gitignore")) ignore := gitignore.NewRepositoryWithCache(root, ".gitignore", gitignore.NewCache(), func(e gitignore.Error) bool {
bomingzh marked this conversation as resolved Outdated
张泊明518370910136 commented 2024-10-17 16:48:50 +08:00
Outdated
Review
Copy Link
  1. Check the existence of the root .gitignore file
  2. The .gitignore file may appear in sub-dirs, you also need to check them
1. Check the existence of the root `.gitignore` file 2. The `.gitignore` file may appear in sub-dirs, you also need to check them
周赵嘉程521432910016 commented 2024-10-17 16:54:27 +08:00
Outdated
Review
Copy Link

So what's the default pattern if no gitignore? Warn student add a gitignore or set root as default value?

So what's the default pattern if no gitignore? Warn student add a gitignore or set root as default value?
汪睿522370910169 commented 2024-10-17 16:56:30 +08:00
Outdated
Review
Copy Link

what if the gitignore is nonsense? Not every course provide unchangeable gitignore

what if the gitignore is nonsense? Not every course provide unchangeable gitignore
周赵嘉程521432910016 commented 2024-10-17 16:57:59 +08:00
Outdated
Review
Copy Link

Change to locallist and make it work as a gitignore file?

what if the gitignore is nonsense? Not every course provide unchangeable gitignore

Change to locallist and make it work as a gitignore file? > what if the gitignore is nonsense? Not every course provide unchangeable gitignore
manuel commented 2024-10-17 16:58:24 +08:00
Outdated
Review
Copy Link

with JOJ3 they must have an immutable gitignore or the server will quickly become a massive mess... caught a student who wanted to see what happened if he pushd a movie... repo was 2.8GB :/

with JOJ3 they **must** have an immutable gitignore or the server will quickly become a massive mess... caught a student who wanted to see what happened if he pushd a movie... repo was 2.8GB :/
😆 1 🚀 1
张泊明518370910136 commented 2024-10-17 17:03:03 +08:00
Outdated
Review
Copy Link

If the forbidden check is enabled, then just throw error for no root gitignore or wrong root gitignore.

If the forbidden check is enabled, then just throw error for no root gitignore or wrong root gitignore.
return false
})
var err error
if err != nil { if err != nil {
return nil, err return nil, err
} }