JOJ/JOJ3
25
5
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

fix/nonascii_attributes #69

Merged
张泊明518370910136 merged 11 commits from fix/nonascii_attributes into master 2024-10-21 17:04:53 +08:00
Conversation 5 Commits 11 Files Changed 3 +2 -1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 01798453b3 - Show all commits

3
pkg/healthcheck/nonascii.go
View File

@ -55,7 +55,8 @@ func getNonAscii(root string) ([]string, error) {
if err != nil { if err != nil {
return err return err
} }
if ret, matched := matcher.Match(strings.Split(relPath, "/"), nil); matched && ret["text"].IsUnset() { ret, matched := matcher.Match(strings.Split(relPath, "/"), nil)
zzjc123 marked this conversation as resolved Outdated
张泊明518370910136 commented 2024-10-21 16:52:45 +08:00
Outdated
Review
Copy Link

this line is too long now, should make it in two lines.

this line is too long now, should make it in two lines.
if matched && ret["text"].IsUnset() {
return nil return nil
} }
} }
zzjc123 marked this conversation as resolved Outdated
张泊明518370910136 commented 2024-10-21 16:08:28 +08:00
Outdated
Review
Copy Link

just

			if _, ret := matcher.Match(strings.Split(relPath, "/"), nil); ret {
				return nil
			}
just ```go if _, ret := matcher.Match(strings.Split(relPath, "/"), nil); ret { return nil } ```