JOJ/JOJ3
25
6
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

fix/nonascii_attributes #69

Merged
张泊明518370910136 merged 11 commits from fix/nonascii_attributes into master 2024-10-21 17:04:53 +08:00
Conversation 5 Commits 11 Files Changed 3 -4
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c7b8cda34d - Show all commits

4
pkg/healthcheck/nonascii.go
View File

@ -50,10 +50,6 @@ func getNonAscii(root string) ([]string, error) {
}
}
if info.Name() == "healthcheck" {
return nil
}
if gitattrExist {
relPath, err := filepath.Rel(root, path)
zzjc123 marked this conversation as resolved Outdated
张泊明518370910136 commented 2024-10-21 16:09:56 +08:00
Outdated
Review
Copy Link

and can this healthcheck skip be removed now?

and can this healthcheck skip be removed now?
周赵嘉程521432910016 commented 2024-10-21 16:29:49 +08:00
Outdated
Review
Copy Link

no we can't for now.

no we can't for now.
张泊明518370910136 commented 2024-10-21 16:37:11 +08:00
Outdated
Review
Copy Link

what about now?

what about now?
周赵嘉程521432910016 commented 2024-10-21 16:41:14 +08:00
Outdated
Review
Copy Link

what do you mean? for now we still need to copy the healthcheck bin into /w to run for test case. I don't now what's the better solution.

what do you mean? for now we still need to copy the healthcheck bin into /w to run for test case. I don't now what's the better solution.
周赵嘉程521432910016 commented 2024-10-21 16:43:00 +08:00
Outdated
Review
Copy Link

oh sorry, I didn't see your commit. I will try it soon.

oh sorry, I didn't see your commit. I will try it soon.
周赵嘉程521432910016 commented 2024-10-21 16:52:48 +08:00
Outdated
Review
Copy Link

it got fixed.

it got fixed.
if err != nil {