style: fix codacy

This commit is contained in:
张泊明518370910136 2021-11-04 01:47:38 +08:00
parent 40703f2126
commit e8f5bd7a08
No known key found for this signature in database
GPG Key ID: FBEF5DE8B9F4C629
2 changed files with 6 additions and 4 deletions

View File

@ -122,8 +122,8 @@ def prepare_assignment_dir(dir_or_zip_file: Path) -> None:
help="upload assignment grades to canvas from grade file (GRADE.txt by default), " help="upload assignment grades to canvas from grade file (GRADE.txt by default), "
+ "read the first line as grade, the rest as comments", + "read the first line as grade, the rest as comments",
) )
def upload_assignment_grades(dir_or_zip_file: Path, assignment_name: str) -> None: def upload_assignment_grades(assignments_dir: Path, assignment_name: str) -> None:
tea.pot.canvas.upload_assignment_grades(str(dir_or_zip_file), assignment_name) tea.pot.canvas.upload_assignment_grades(str(assignments_dir), assignment_name)
if __name__ == "__main__": if __name__ == "__main__":

View File

@ -99,7 +99,9 @@ class Canvas:
tmp = ", ".join([str(student) for student in late_students]) tmp = ", ".join([str(student) for student in late_students])
logger.info(f"Late student(s): {tmp}") logger.info(f"Late student(s): {tmp}")
def upload_assignment_grades(self, dir: str, assignment_name: str) -> None: def upload_assignment_grades(
self, assignments_dir: str, assignment_name: str
) -> None:
assignment = first(self.assignments, lambda x: x.name == assignment_name) assignment = first(self.assignments, lambda x: x.name == assignment_name)
if assignment is None: if assignment is None:
logger.info(f"Canvas assignment {assignment_name} not found") logger.info(f"Canvas assignment {assignment_name} not found")
@ -113,7 +115,7 @@ class Canvas:
if student is None: if student is None:
continue continue
grade_file_path = os.path.join( grade_file_path = os.path.join(
dir, student.sis_login_id, self.grade_filename assignments_dir, student.sis_login_id, self.grade_filename
) )
try: try:
grade, *comments = list(open(grade_file_path)) grade, *comments = list(open(grade_file_path))