张泊明518370910136 bomingzh
0 Followers · 0 Following
Repositories Projects Packages Public Activity Starred Repositories
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 15:51:09 +08:00
dev

will it be None now?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 15:49:07 +08:00
dev

what needs to be refined?

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 15:48:15 +08:00
3751eb84a6 refactor: sanity check & minor optimization
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 15:43:06 +08:00
dev

They can manually add it if needed. Or just move it to the model default.

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 15:33:20 +08:00
a5680bb3bc perf: better keyword time complexity
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 15:28:17 +08:00
01949f136a chore: lint error
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 15:26:32 +08:00
855b35592f refactor: clear health check args generation
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 15:23:44 +08:00
dev

ParserEnum

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 15:22:11 +08:00
dev

do we need that default?

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 15:14:23 +08:00
76b2a3c104 fix: python3.9 typing
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 15:13:34 +08:00
c1c8e6ff3d fix: python3.9 Union
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 15:06:46 +08:00
dev

what compact?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 13:34:02 +08:00
dev

No, just inherit from (str, Enum).

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 12:28:00 +08:00
dev

better put all defaults here then we only need to check the code here

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 11:46:10 +08:00
d6a33d2f20 feat: only support str limit in toml
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 11:45:29 +08:00
dev

yes

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 11:40:52 +08:00
dev

also these Optional?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 11:39:06 +08:00
dev

line changed, the comment is for parsers

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 11:05:37 +08:00
dev

yes, just str

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 10:54:06 +08:00
30fae62b67 test: use load.py for joj1