张泊明518370910136 bomingzh
0 Followers · 0 Following
Repositories Projects Packages Public Activity Starred Repositories
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 10:43:07 +08:00
dev

Are these Optional necessary?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 10:41:11 +08:00
dev

Then why is there a stdout field in class Limit

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 10:35:35 +08:00
dev

if unused, leave a comment

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 10:11:45 +08:00
dev

is it used?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 10:05:48 +08:00
dev

str here need to be a StrEnum now.

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 10:03:29 +08:00
25da08ecfc style: force parser.with be a BaseModel
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 09:00:28 +08:00
dev

parsers name should be a str enum, force them to use the correct names

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 04:45:11 +08:00
f3ed1db5b2 refactor: move load logic to separate file
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 04:25:24 +08:00
3b40bee13c test: use tests/convert as root
56ecd35e46 refactor: use dict instead of set for consistent order
e0da740871 style: rename class
Compare 3 commits »
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:14 +08:00
dev

When will it be None?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:14 +08:00
dev

Just pass conf_stage.executor to this function rather then the whole conf_stage.

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:14 +08:00
dev

Pass JOJ3_CONFIG_ROOT / task_conf.path.parent as base_dir in parameters.

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:14 +08:00
dev

Do we need to support both kinds of names?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:14 +08:00
dev

When will it be None?

张泊明518370910136 suggested changes for JOJ/JOJ3-config-generator#10 2025-03-05 04:11:14 +08:00
dev
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:13 +08:00
dev

The reason for the suffix in keyword_parser_?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:13 +08:00
dev

Should it be optional?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:13 +08:00
dev

Is it necessary to rename?

张泊明518370910136 pushed to master at JOJ/JOJ3 2025-03-04 07:41:47 +08:00
8924f174b4 feat(parser/diff): log index & isSame
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-04 03:05:54 +08:00
dev

In joj3_config_generator/models/task.py, Config.path is relative to JOJ3_CONFIG_ROOT, so task.toml will located at JOJ3_CONFIG_ROOT / task_conf.path in JTC.