张泊明518370910136 bomingzh
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 04:01:41 +08:00
6b5d941eb1 chore: move path to const
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 03:43:53 +08:00
dev

where is it used?

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 03:41:23 +08:00
4b3668d772 chore: remove joj1 part
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 03:35:14 +08:00
10f2d5c94b style: rename
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 03:31:25 +08:00
5444debb92 feat: better release time default
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 03:26:50 +08:00
3e252e1ff0 chore: better defaults and code style
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 02:25:47 +08:00
6bdd689176 fix: outdated workflow yaml
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 17:14:06 +08:00
6fc162769f test: reasonable limits
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 17:05:21 +08:00
dev

and use underscore naming in this file

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 17:01:13 +08:00
a119adf80f feat: support both int & str as limit input
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 16:42:30 +08:00
dev

every field in this file should not be optional. we give an default value here if any field does not exist

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 16:38:43 +08:00
8164e75058 feat: time & mem consts and defaults
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 15:50:26 +08:00
dev

just use humanfriendly.parse_timespan

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 15:46:32 +08:00
46cafc0ed6 fix: typo
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 12:15:54 +08:00
dev

I mean

if parser not in keyword_parser:
    continue
if getattr(task_stage, parser, None) is None:
    continue
if score != score_:
    continue
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 12:15:34 +08:00
dev

I mean

if parser not in keyword_parser:
    continue
if getattr(task_stage, parser, None) is None:
    continue
if score != score_:
    continue
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 12:09:26 +08:00
dev
class DummyConfig(BaseModel):
    score: int
    comment: str

Then dummy_parser_.with_.update(dummy_config(...).model_dump()).

张泊明518370910136 pushed to master at JOJ/JOJ3 2025-03-02 11:59:39 +08:00
5228a97cc1 chore(stage): rename score map var
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 10:36:39 +08:00
dev

Is pre-commit on your local dev env installed correctly?

for pycln it has some path issue so I skip it and run pycln . locally to do the test (sometimes I may forgot...)

You…

张泊明518370910136 pushed to master at JOJ/JOJ3 2025-03-02 09:49:25 +08:00
cd36469f49 test: remove unstable clangtidy test