张泊明518370910136 bomingzh
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-28 20:19:11 +08:00
dev

Tests not passed

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-28 03:06:43 +08:00
dev

no

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:26:53 +08:00
dev

default value too large, should be 1s 128MB

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:24:24 +08:00
dev

why?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:21:11 +08:00
dev

why?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:20:25 +08:00
dev

Why does this test need immutable files?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:15:26 +08:00
dev

why here?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:10:53 +08:00
dev

Then click the "Resolve conversation" button.

Rebase is needed, some codes are not from latest master.

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:05:17 +08:00
dev

Are all the old conversations resolved?

张泊明518370910136 pushed to master at JOJ/JOJ3-config-generator 2025-02-27 14:28:51 +08:00
aee123601f fix: root path for tests
ae77fa23b5 fix: default path for tests
870f20dde9 chore: remove unused utils
Compare 3 commits »
张泊明518370910136 pushed to master at JOJ/JOJ3-config-generator 2025-02-27 14:17:27 +08:00
723705b94f fix: store path for both conf objs
张泊明518370910136 pushed to master at JOJ/JOJ3-config-generator 2025-02-27 14:15:16 +08:00
4c12bf9a34 fix: store root path
张泊明518370910136 pushed to master at JOJ/JOJ3-config-generator 2025-02-27 13:24:55 +08:00
c4639aef76 fix: store relative path to root
张泊明518370910136 pushed to master at JOJ/JOJ3 2025-02-26 15:20:40 +08:00
7af18aebe8 fix(healthcheck): remove meta check extra prefix
张泊明518370910136 pushed to master at JOJ/JOJ3-config-generator 2025-02-26 03:07:29 +08:00
ab5bfc6cfe fix: find repo.toml recursively
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-25 17:16:00 +08:00
dev

this file should not be changed

张泊明518370910136 pushed to master at JOJ/JOJ3-config-generator 2025-02-25 17:15:15 +08:00
67d2fcc4e4 feat: dump with exclude_none
张泊明518370910136 pushed to master at JOJ/JOJ3-config-generator 2025-02-25 16:48:18 +08:00
68628c0eae feat: convert toml files recursively
张泊明518370910136 pushed to master at JOJ/JOJ3 2025-02-25 16:12:44 +08:00
76a140d6a2 ci: use local checkout
张泊明518370910136 pushed to master at JOJ/JOJ3-config-generator 2025-02-25 16:12:32 +08:00
73f2581a31 ci: use local checkout