张泊明518370910136 bomingzh
0 Followers · 0 Following
Repositories Projects Packages Public Activity Starred Repositories
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 15:13:34 +08:00
c1c8e6ff3d fix: python3.9 Union
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 15:06:46 +08:00
dev

what compact?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 13:34:02 +08:00
dev

No, just inherit from (str, Enum).

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 12:28:00 +08:00
dev

better put all defaults here then we only need to check the code here

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 11:46:10 +08:00
d6a33d2f20 feat: only support str limit in toml
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 11:45:29 +08:00
dev

yes

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 11:40:52 +08:00
dev

also these Optional?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 11:39:06 +08:00
dev

line changed, the comment is for parsers

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 11:05:37 +08:00
dev

yes, just str

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 10:54:06 +08:00
30fae62b67 test: use load.py for joj1
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 10:43:07 +08:00
dev

Are these Optional necessary?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 10:41:11 +08:00
dev

Then why is there a stdout field in class Limit

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 10:35:35 +08:00
dev

if unused, leave a comment

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 10:11:45 +08:00
dev

is it used?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 10:05:48 +08:00
dev

str here need to be a StrEnum now.

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 10:03:29 +08:00
25da08ecfc style: force parser.with be a BaseModel
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 09:00:28 +08:00
dev

parsers name should be a str enum, force them to use the correct names

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 04:45:11 +08:00
f3ed1db5b2 refactor: move load logic to separate file
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 04:25:24 +08:00
3b40bee13c test: use tests/convert as root
56ecd35e46 refactor: use dict instead of set for consistent order
e0da740871 style: rename class
Compare 3 commits »
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:14 +08:00
dev

Pass JOJ3_CONFIG_ROOT / task_conf.path.parent as base_dir in parameters.