张泊明518370910136 bomingzh
0 Followers · 0 Following
Repositories Projects Packages Public Activity Starred Repositories
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:14 +08:00
dev

Just pass conf_stage.executor to this function rather then the whole conf_stage.

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:14 +08:00
dev

Pass JOJ3_CONFIG_ROOT / task_conf.path.parent as base_dir in parameters.

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:14 +08:00
dev

When will it be None?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:14 +08:00
dev

Do we need to support both kinds of names?

张泊明518370910136 suggested changes for JOJ/JOJ3-config-generator#10 2025-03-05 04:11:14 +08:00
dev
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:13 +08:00
dev

Should it be optional?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:13 +08:00
dev

The reason for the suffix in keyword_parser_?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 04:11:13 +08:00
dev

Is it necessary to rename?

张泊明518370910136 pushed to master at JOJ/JOJ3 2025-03-04 07:41:47 +08:00
8924f174b4 feat(parser/diff): log index & isSame
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-04 03:05:54 +08:00
dev

In joj3_config_generator/models/task.py, Config.path is relative to JOJ3_CONFIG_ROOT, so task.toml will located at JOJ3_CONFIG_ROOT / task_conf.path in JTC.

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-04 03:02:45 +08:00
dev

Use a dict to store parser name, field, function to process.

    process_dict: Dict[
        str, Tuple[Callable[[result.ParserConfig, BaseModel], None], BaseModel]
    ] = {
       …
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 13:43:12 +08:00
dev

No, do not find the parser in the fix_xxx function. Instead, iterate through the parsers here and decide how to fill in the with.

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:54:43 +08:00
dev

should loop through conf_stage.parsers here and update the with field according to the parser name.

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 11:52:00 +08:00
c36e710668 refactor: better code style
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:27:04 +08:00
dev

Some with_.update is still using raw dict, not model with model_dump.

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:25:43 +08:00
dev

not necessary

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:22:55 +08:00
dev

do not use getattr, visit the field explictly

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:18:14 +08:00
dev

What is the conclusion?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:17:54 +08:00
dev

Never heard about this rule.

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:15:21 +08:00
dev

config.path is relative to JOJ3_CONFIG_ROOT.