张泊明518370910136 bomingzh
0 Followers · 0 Following
Repositories Projects Packages Public Activity Starred Repositories
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:03:41 +08:00
dev

Path should not be relative to JOJ3_CONFIG_ROOT in this file, should be relative to task.toml dir

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 10:58:32 +08:00
dev

try it yourself

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 10:55:00 +08:00
dev
  1. The return value is unnecessary
  2. It should be a set
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 10:44:19 +08:00
dev

The return value is unnecessary.

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 10:33:33 +08:00
dev

so this feature is not implemented?

张泊明518370910136 pushed to master at JOJ/JOJ3 2025-03-03 09:59:43 +08:00
187b5f7057 chore(stage): detail log field name
张泊明518370910136 pushed to master at JOJ/JOJ3 2025-03-03 09:45:11 +08:00
d51fb9f35d feat(stage): log stage detail
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 04:33:51 +08:00
0c2baf67bd chore: better code style
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 04:09:33 +08:00
8baca08696 chore: rename var
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 04:05:24 +08:00
8ad4d6f2a0 style: split health check words
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 04:01:41 +08:00
6b5d941eb1 chore: move path to const
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 03:43:53 +08:00
dev

where is it used?

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 03:41:23 +08:00
4b3668d772 chore: remove joj1 part
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 03:35:14 +08:00
10f2d5c94b style: rename
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 03:31:25 +08:00
5444debb92 feat: better release time default
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 03:26:50 +08:00
3e252e1ff0 chore: better defaults and code style
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 02:25:47 +08:00
6bdd689176 fix: outdated workflow yaml
张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 17:14:06 +08:00
6fc162769f test: reasonable limits
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 17:05:21 +08:00
dev

and use underscore naming in this file

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 17:01:13 +08:00
a119adf80f feat: support both int & str as limit input