张泊明518370910136 bomingzh
0 Followers · 0 Following
Repositories Projects Packages Public Activity Starred Repositories
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 16:42:30 +08:00
dev

every field in this file should not be optional. we give an default value here if any field does not exist

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 16:38:43 +08:00
8164e75058 feat: time & mem consts and defaults
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 15:50:26 +08:00
dev

just use humanfriendly.parse_timespan

张泊明518370910136 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 15:46:32 +08:00
46cafc0ed6 fix: typo
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 12:15:54 +08:00
dev

I mean

if parser not in keyword_parser:
    continue

if getattr(task_stage, parser, None) is None:
    continue

if score != score_:
    continue
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 12:15:34 +08:00
dev

I mean

if parser not in keyword_parser:
    continue

if getattr(task_stage, parser, None) is None:
    continue

if score != score_:
    continue
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 12:09:26 +08:00
dev 
class DummyConfig(BaseModel):
    score: int
    comment: str

Then dummy_parser_.with_.update(dummy_config(...).model_dump()).

张泊明518370910136 pushed to master at JOJ/JOJ3 2025-03-02 11:59:39 +08:00
5228a97cc1 chore(stage): rename score map var
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 10:36:39 +08:00
dev

Is pre-commit on your local dev env installed correctly?

for pycln it has some path issue so I skip it and run pycln . locally to do the test (sometimes I may forgot...)

You…

张泊明518370910136 pushed to master at JOJ/JOJ3 2025-03-02 09:49:25 +08:00
cd36469f49 test: remove unstable clangtidy test
张泊明518370910136 pushed to healthcheck/meta at JOJ/JOJ3-examples 2025-03-02 09:44:17 +08:00
8d2f5585a1 feat: updated parser
张泊明518370910136 pushed to master at JOJ/JOJ3 2025-03-02 09:35:26 +08:00
83885d795f fix(stage): debug log score map from parsers
张泊明518370910136 pushed to master at JOJ/JOJ3 2025-03-02 09:34:27 +08:00
ac9dfffa4c feat(stage): log score map from parsers
张泊明518370910136 suggested changes for JOJ/JOJ3-config-generator#10 2025-03-02 02:37:45 +08:00
dev
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 02:37:44 +08:00
dev

unit?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 02:37:44 +08:00
dev

Create models for these dicts, then update them with the dict from model_dump

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 02:37:44 +08:00
dev
张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 02:37:44 +08:00
dev

move continue to the other branch to reduce nesting

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 02:37:44 +08:00
dev

is it in the correct unit?

张泊明518370910136 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 02:37:44 +08:00
dev

these fields do not exist now