李衍志523370910113 jon-lee
  • 523370910113
  • Joined on 2023-09-10
李衍志523370910113 pushed to fix/diff at JOJ/JOJ3-config-generator 2025-03-18 15:46:04 +08:00
e4246ecf45 feat(diff): add auto detect testcases feature
李衍志523370910113 opened issue JOJ/JOJ3-config-generator#12 2025-03-18 14:18:36 +08:00
fix the duplication of default value and support multiple testcases name in diff
李衍志523370910113 pushed to fix/diff at JOJ/JOJ3-config-generator 2025-03-18 14:15:16 +08:00
李衍志523370910113 created branch fix/diff in JOJ/JOJ3-config-generator 2025-03-18 14:15:16 +08:00
李衍志523370910113 deleted branch archive/dev from JOJ/JOJ3-config-generator 2025-03-05 16:22:30 +08:00
李衍志523370910113 pushed to master at JOJ/JOJ3-config-generator 2025-03-05 16:20:41 +08:00
9213e57ca3 dev (#10)
李衍志523370910113 merged pull request JOJ/JOJ3-config-generator#10 2025-03-05 16:20:39 +08:00
dev
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 16:14:45 +08:00
5a6cfd1475 style: schedule TODO for file management
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 16:09:52 +08:00
dev

so far works fine on 280 sides, indicating that pbs in 151 can be resolved with proper guidelines I think.

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 15:57:12 +08:00
85e358d3b7 chore: remove unnecesarry None check
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 15:54:16 +08:00
dev

nope 😂 bad coding strategy before

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 15:53:51 +08:00
9f4eda337b chore: remove redundant comment
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 15:52:55 +08:00
dev

just feels bit waste since this outputs only have one field before I coded the logic, I wrote that comment without checking the details of diff parser. But it should be the best strategy to show…

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 15:50:43 +08:00
dev

removed.

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 15:50:34 +08:00
6ee7068bfa fix: remove defualt num for groups
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 15:42:58 +08:00
34ce4b0e13 chore: rename parser_enum->ParserEnum
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 15:41:30 +08:00
dev

what is the situation internally in JOJ3? I just added that blindly when I reached that stage. Overall I think 100 times per day should be a reasonable and safe default? considering that there may…

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 15:21:39 +08:00
38f0bc8598 chore: remove outdated FIXME
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 15:20:02 +08:00
dev

no int input, should be done already, so it can be removed. I added that several commit before before you removed that 😇

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 13:37:20 +08:00
63f154c540 fix: use (str, Enum)