李衍志523370910113 jon-lee
2 Followers · 1 Following
  • 523370910113
  • Joined on 2023-09-10
Repositories Projects Packages Public Activity Starred Repositories
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 13:34:36 +08:00
dev

OK

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 13:32:42 +08:00
e4027ad908 fix: update rtoml version
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 13:29:12 +08:00
d1a9530758 feat: change python version to 3.11
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 13:14:06 +08:00
dev

@bomingzh

joj3_config_generator/models/task.py:2: error: Module "enum" has no attribute "StrEnum"  [attr-defined]

we probably need to update some dependencies

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 13:08:38 +08:00
3a75169e8c fix(models/result): remove Optionals for ParserConfigs
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 13:06:03 +08:00
dev

indeed.

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 13:05:31 +08:00
dev

It is supported now.

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 13:03:55 +08:00
345f6daa32 feat: implement StrEnum for parser
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 13:03:20 +08:00
924325b933 fix: num -> string in toml
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 12:25:45 +08:00
dev

I guess some of the field have default within JOJ3, so I choose optional just to reduce the length of json previously

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 11:43:07 +08:00
dev

this should be the StrEnum

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 11:33:58 +08:00
dev

But I guess we don't know the set of case in advance, making it dynamic StrEnum is meaningless

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 11:15:13 +08:00
719f19232b fix: pass test
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 11:13:25 +08:00
deb90a02ca feat: time and memory parse
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 11:02:19 +08:00
dev

I reckon only 32m would be good

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 11:01:49 +08:00
dev

@bomingzh in toml now should we accept both 32m and 32 or just 32m now?

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 10:25:11 +08:00
dev

testcases in basic is intend to show a comprehensive situation.

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 09:09:46 +08:00
dev

ok, then removed.

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-05 09:09:38 +08:00
53819e63a2 fix: do not allow multiple name
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-05 08:53:49 +08:00
dev

resolved.