李衍志523370910113 jon-lee
2 Followers · 1 Following
  • 523370910113
  • Joined on 2023-09-10
Repositories Projects Packages Public Activity Starred Repositories
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 12:30:17 +08:00
dev

should be already solved.

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:19:19 +08:00
dev

@manuel what would be the current intended rule for group?

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:12:45 +08:00
dev

BTW, is this outdated?

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:11:32 +08:00
dev

I reckon you said things is relative to JOJ3_CONFIG_ROOT in JTC before. we have a task.type in task.toml to mend the path

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:09:22 +08:00
dev

resolved.

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-03 11:09:18 +08:00
635405ea2b fix(convert): use set instead list for cached
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 11:05:15 +08:00
dev

I see why

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 10:48:07 +08:00
dev

I have a lazing coding style here, everything has get imported would get exported, so should maintain this until the end of the loop. Everything is exported in previous stage would be imported in…

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 10:38:31 +08:00
dev 
    if not repo_conf.force_skip_health_check_on_test or not current_test:
        result_conf.stage.stages.append(get_health_check_config(repo_conf))
    cached: List[str] = []
    #…
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 10:33:32 +08:00
dev

It is as the input and output for the following functions about parsers

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-03 10:31:09 +08:00
dev

this should be storing all the files that are about to be copy in or out

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 18:12:31 +08:00
dev

seems updated, mark as resolved.

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 18:10:40 +08:00
dev

and use underscore naming in this file

fixed.

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 18:10:25 +08:00
26ea5cfd8e fix: typo
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 18:06:57 +08:00
dev

every field in this file should not be optional. we give an default value here if any field does not exist fixed

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 18:06:31 +08:00
82fa325cf6 fix: remove Optional and fix its dependent code
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 17:38:50 +08:00
dev

fixed.

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 17:38:42 +08:00
dev

fixed

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 17:38:36 +08:00
5c1eede217 fix(processors/task): parser model dump
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 17:29:44 +08:00
b8bd3feccb fix(models/result): wrong alias