李衍志523370910113 jon-lee
2 Followers · 1 Following
  • 523370910113
  • Joined on 2023-09-10
Repositories Projects Packages Public Activity Starred Repositories
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 10:41:35 +08:00
dev

resolved

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-02 10:41:20 +08:00
f676050575 fix: deadline -> end_time
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-02 10:32:05 +08:00
dev

Is pre-commit on your local dev env installed correctly?

for pycln it has some path issue so I skip it and run pycln . locally to do the test (sometimes I may forgot...)

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-03-01 20:48:22 +08:00
dev

@bomingzh test can pass now, with conflict with master fixed.

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-01 20:47:44 +08:00
e7f8f5bb94 fix: pass test
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-01 20:46:31 +08:00
b587d2c63a fix: merge master
f5b7563869 feat: union type cmd files
Compare 2 commits »
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-03-01 20:21:10 +08:00
5601b46ffa fix: pass test
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-28 10:33:56 +08:00
dev

@bomingzh fixed

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-02-28 10:33:45 +08:00
e87b3ca775 fix: default size change to 1s & 128m
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:38:13 +08:00
dev

will fix later, we need to hold some test I reckon?

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:27:52 +08:00
dev

fixed

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-02-27 16:27:49 +08:00
aa678484ee chore: remove absolute root
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:25:57 +08:00
dev

fixed

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:25:51 +08:00
dev

fixed

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-02-27 16:25:45 +08:00
9fff4a9aca chore(*/immutable_files): remove redundant test files
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:23:10 +08:00
dev

you are right

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:22:46 +08:00
dev

forgot to uncommented 😭

李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2025-02-27 16:18:58 +08:00
63b9b9e47b docs(README): fix typo
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:18:11 +08:00
dev

you mean the existence of the file? I design the logic of immutable folders to be like this:

[nuvole0217@Nuvole test]$ tree .
.
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#10 2025-02-27 16:14:10 +08:00
dev

I merged master here JOJ/JOJ3-config-generator#11, and double checked, should all be fine I guess? Do you have more suggestions on the code and adding…