From 89172137fe458ad932e3396b5e3b2448d982ced6 Mon Sep 17 00:00:00 2001
From: BoYanZh <bomingzh@sjtu.edu.cn>
Date: Thu, 19 May 2022 23:00:45 +0800
Subject: [PATCH] chore: make lgtm happy

---
 joint_teapot/workers/gitea.py | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/joint_teapot/workers/gitea.py b/joint_teapot/workers/gitea.py
index 14f755d..01936d7 100644
--- a/joint_teapot/workers/gitea.py
+++ b/joint_teapot/workers/gitea.py
@@ -1,7 +1,7 @@
 from datetime import datetime
 from enum import Enum
 from functools import lru_cache
-from typing import Any, Callable, Dict, List, Optional, Tuple
+from typing import Any, Callable, Dict, Iterable, List, Optional, Tuple, TypeVar
 
 import focs_gitea
 from canvasapi.group import Group, GroupMembership
@@ -20,7 +20,10 @@ class PermissionEnum(Enum):
     admin = "admin"
 
 
-def list_all(method: Callable[..., Any], *args: Any, **kwargs: Any) -> Any:
+T = TypeVar("T")
+
+
+def list_all(method: Callable[..., Iterable[T]], *args: Any, **kwargs: Any) -> List[T]:
     all_res = []
     page = 1
     while True:
@@ -171,10 +174,9 @@ class Gitea:
                     },
                 )
                 logger.info(f"{self.org_name}/{team_name} created")
-            repo = first(repos, lambda repo: repo.name == repo_name)
-            if repo is None:
+            if first(repos, lambda repo: repo.name == repo_name) is None:
                 repo_names.append(repo_name)
-                repo = self.organization_api.create_org_repo(
+                self.organization_api.create_org_repo(
                     self.org_name,
                     body={
                         "auto_init": False,