周赵嘉程521432910016 zzjc123
  • 521432910016
  • Joined on 2022-09-12
周赵嘉程521432910016 pushed to fix/nonascii_attributes at JOJ/JOJ3 2024-10-21 15:26:10 +08:00
c8f377245f fix(healthcheck/utils): unused function
周赵嘉程521432910016 pushed to fix/nonascii_attributes at JOJ/JOJ3 2024-10-21 15:18:47 +08:00
348eaa247c feat(healthcheck/nonascii): ignore content in gitattributes
周赵嘉程521432910016 created branch fix/nonascii_attributes in JOJ/JOJ3 2024-10-21 13:01:52 +08:00
周赵嘉程521432910016 pushed to fix/nonascii_attributes at JOJ/JOJ3 2024-10-21 13:01:52 +08:00
55e2b38583 feat(healthcheck/nonascii): ignore content in gitattributes
周赵嘉程521432910016 commented on issue JOJ/JOJ3#62 2024-10-18 14:58:13 +08:00
Healthchecker cannot properly catch the error for different hash

which server are you using @jon-lee I didn't log to the server for a long time

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-18 14:50:13 +08:00
fix/forbidden (#58)

so you want to test whether the subdir of a subdir containing .gitignore follow the rule in the subdir?

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-18 14:32:58 +08:00
fix/forbidden (#58)

create a new pr for it?

Now the hc parser is hardcoded to read stdout from file ./stdout and stderr from file ./stderr. But with this check, they can not be hardcoded, make them a config option.

周赵嘉程521432910016 pushed to fix/forbidden at JOJ/JOJ3 2024-10-18 14:31:04 +08:00
240cc571bd Merge branch 'master' into fix/forbidden
ff0b0957eb refactor(cmd/joj3): backward compatible arg order [force build]
fcc1f1856f feat(cmd/joj3): pass commit hash to teapot [force build]
7ff6dfb002 fix(parser/clangtidy): ignore empty lines
e44537ea95 feat(cmd/joj3): issue with actor [force build]
Compare 6 commits »
周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-18 14:30:58 +08:00
fix/forbidden (#58)

.c file should be ignored or included by which gitignore?

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-18 14:30:26 +08:00
fix/forbidden (#58)

what do you mean? not sure about it

what if you add test1/test2/test.c?

do we need to have a gitignore in each in each folder?

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 19:46:57 +08:00
fix/forbidden (#58)

@manuel like this?

❯ ../JOJ3/build/healthcheck -root=.

Forbidden File Check Failed:

The following forbidden files were found: conf.json, expected.json, test/.DS_Store, test1,…

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 18:40:58 +08:00
fix/forbidden (#58)

add a simple case here but I'm afraid that it is too simple. https://focs.ji.sjtu.edu.cn/git/JOJ/JOJ3-examples/src/branch/healthcheck/forbiddenfile

can anyone think about some more tricky cases.

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 18:23:43 +08:00
fix/forbidden (#58)

seems easier than i think @bomingzh plz check it. i don't sure is this function correctly implemented in package.

周赵嘉程521432910016 pushed to fix/forbidden at JOJ/JOJ3 2024-10-17 18:20:20 +08:00
44e3feb5c6 feat(healthcheck/forbidden): gitignore in subdir
周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 17:14:51 +08:00
fix/forbidden (#58)

may be done this weekend

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 17:13:43 +08:00
fix/forbidden (#58)

may need some time for this feature. A little busy recently.

The .gitignore file may appear in sub-dirs, you also need to check them

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 16:57:59 +08:00
fix/forbidden (#58)

Change to locallist and make it work as a gitignore file?

what if the gitignore is nonsense? Not every course provide unchangeable gitignore

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 16:56:05 +08:00
fix/forbidden (#58)

ignore the /w/tmp/?

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 16:55:36 +08:00
fix/forbidden (#58)

Also, add an option to healthcheck parser for stdout and stderr as we need to put them to /tmp/stdout and /tmp/stderr.

not sure what did you mean, can you explain more detailedly?

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 16:54:27 +08:00
fix/forbidden (#58)

So what's the default pattern if no gitignore? Warn student add a gitignore or set root as default value?