JOJ/JOJ3-config-generator
27
1
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor/main #11

Merged
李衍志523370910113 merged 23 commits from refactor/main into dev 2025-02-27 15:51:32 +08:00
Conversation 1 Commits 23 Files Changed 40 +619 -694
李衍志523370910113 commented 2025-02-27 10:00:09 +08:00
Member
Copy Link

what I have done

  • sync main function in master branch and tested current code usage
  • remove redundant code
  • update README documents
  • fix the immutable files logic

TODO

  • give fallback options for immutable files
# what I have done - sync main function in master branch and tested current code usage - remove redundant code - update README documents - fix the immutable files logic ## TODO - give fallback options for immutable files
李衍志523370910113 added 9 commits 2025-02-27 10:00:09 +08:00
ci: only use runs-on
All checks were successful
build / build (push) Successful in 2m31s
Details
acbcda9565
docs(README): list pdm run
All checks were successful
build / build (push) Successful in 2m28s
Details
2bf1a225b6
test: allow non-exist toml file input
All checks were successful
build / build (push) Successful in 2m36s
Details
bddb67decf
ci: use local checkout
All checks were successful
build / build (push) Successful in 4m22s
Details
73f2581a31
feat: convert toml files recursively
All checks were successful
build / build (push) Successful in 2m28s
Details
68628c0eae
feat: dump with exclude_none
All checks were successful
build / build (push) Successful in 2m26s
Details
67d2fcc4e4
fix: find repo.toml recursively
All checks were successful
build / build (push) Successful in 2m23s
Details
ab5bfc6cfe
fix: conflict with master
Some checks failed
build / build (push) Failing after 2m32s
Details
c19801f9a1
refactor(convert): remove distribute json
Some checks failed
build / build (push) Failing after 2m18s
Details
build / build (pull_request) Failing after 2m22s
Details
2a2387fff2
李衍志523370910113 self-assigned this 2025-02-27 10:00:18 +08:00
李衍志523370910113 added the
enhancement
 label 2025-02-27 10:00:24 +08:00
李衍志523370910113 added 1 commit 2025-02-27 10:07:19 +08:00
docs: update README
Some checks failed
build / build (push) Failing after 2m27s
Details
build / build (pull_request) Failing after 2m26s
Details
789137d498
李衍志523370910113 added 1 commit 2025-02-27 10:11:46 +08:00
docs: update README
Some checks failed
build / build (pull_request) Failing after 2m24s
Details
build / build (push) Failing after 2m26s
Details
b5c43eacb3
李衍志523370910113 added 1 commit 2025-02-27 11:29:03 +08:00
chore: restructure immutable files
Some checks failed
build / build (push) Has been cancelled
Details
build / build (pull_request) Failing after 2m32s
Details
4adda6e716
李衍志523370910113 added 1 commit 2025-02-27 11:30:00 +08:00
fix: absolute path & immutable files feature
Some checks failed
build / build (pull_request) Failing after 2m27s
Details
build / build (push) Failing after 2m29s
Details
99ccbbd113
李衍志523370910113 reviewed 2025-02-27 11:34:26 +08:00
joj3_config_generator/main.py Outdated
@ -85,0 +73,4 @@
)
task_obj = rtoml.loads(task_toml_path.read_text())
repo_conf = repo.Config(**repo_obj)
repo_conf.path = (root / repo_toml_path.relative_to(root)).resolve()
李衍志523370910113 commented 2025-02-27 11:34:26 +08:00
Author
Member
Copy Link

repo_conf.path as absolute

`repo_conf.path` as absolute
李衍志523370910113 reviewed 2025-02-27 11:34:27 +08:00
joj3_config_generator/main.py
@ -82,3 +62,1 @@
# to be used in real action
folder_path = f"{root}"
distribute_json(folder_path, repo_obj, repo_path)
root = root.absolute()
李衍志523370910113 commented 2025-02-27 11:34:27 +08:00
Author
Member
Copy Link

@bomingzh can we consder here to make repo_conf.path to store the abosolute value?

@bomingzh can we consder here to make `repo_conf.path` to store the abosolute value?
李衍志523370910113 reviewed 2025-02-27 11:34:42 +08:00
joj3_config_generator/main.py Outdated
@ -85,0 +75,4 @@
repo_conf = repo.Config(**repo_obj)
repo_conf.path = (root / repo_toml_path.relative_to(root)).resolve()
task_conf = task.Config(**task_obj)
task_conf.path = (root / task_toml_path.relative_to(root)).resolve()
李衍志523370910113 commented 2025-02-27 11:34:42 +08:00
Author
Member
Copy Link

task_conf.path as absolute

`task_conf.path` as absolute
张泊明518370910136 was assigned by 李衍志523370910113 2025-02-27 11:35:02 +08:00
李衍志523370910113 added 4 commits 2025-02-27 14:28:26 +08:00
fix: store relative path to root
All checks were successful
build / build (push) Successful in 2m46s
Details
c4639aef76
fix: store root path
Some checks failed
build / build (push) Has been cancelled
Details
4c12bf9a34
fix: store path for both conf objs
All checks were successful
build / build (push) Successful in 2m21s
Details
723705b94f
fix: merge master
Some checks failed
build / build (push) Failing after 2m28s
Details
build / build (pull_request) Failing after 2m29s
Details
1a1ed96c23
李衍志523370910113 added 4 commits 2025-02-27 14:37:43 +08:00
fix: root path for tests
All checks were successful
build / build (push) Successful in 2m23s
Details
aee123601f
fix: merge master
Some checks failed
build / build (pull_request) Failing after 2m34s
Details
build / build (push) Failing after 2m32s
Details
adfdc027f2
李衍志523370910113 added 1 commit 2025-02-27 15:31:11 +08:00
fix: pass pytest
All checks were successful
build / build (push) Successful in 2m29s
Details
build / build (pull_request) Successful in 2m27s
Details
1f0ee639dd
李衍志523370910113 commented 2025-02-27 15:34:19 +08:00
Author
Member
Copy Link

@bomingzh Hi boming, this pr pass test, can you plz review it and give approvement? :)

@bomingzh Hi boming, this pr pass test, can you plz review it and give approvement? :)
李衍志523370910113 added 1 commit 2025-02-27 15:45:29 +08:00
fix(diff): get cases path
All checks were successful
build / build (pull_request) Successful in 2m32s
Details
build / build (push) Successful in 2m35s
Details
05207037f5
李衍志523370910113 changed title from WIP: refactor/main to refactor/main 2025-02-27 15:51:20 +08:00
李衍志523370910113 merged commit 347c4b91d5 into dev 2025-02-27 15:51:32 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
李衍志523370910113
张泊明518370910136
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: JOJ/JOJ3-config-generator#11
No description provided.
Delete Branch "refactor/main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?