JOJ/JOJ3-config-generator
27
1
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

docs: full toml sample (#20) #27

Merged
张泊明518370910136 merged 7 commits from full-toml-sample into master 2025-07-08 04:38:47 +08:00
Conversation 0 Commits 7 Files Changed 12 +741
张泊明518370910136 commented 2025-06-30 18:34:36 +08:00
Owner
Copy Link

Need proofreading and comments & example values in parsers fields.

Need proofreading and comments & example values in parsers fields.
👍 1
张泊明518370910136 added 1 commit 2025-06-30 18:34:37 +08:00
docs: full toml sample
All checks were successful
build / build (push) Successful in 2m11s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Successful in 2m14s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
52961207dc
张泊明518370910136 force-pushed full-toml-sample from 52961207dc to 3c8c276537 2025-07-01 01:25:23 +08:00 Compare
张泊明518370910136 changed title from WIP: docs: full toml sample to docs: full toml sample 2025-07-01 01:26:17 +08:00
manuel reviewed 2025-07-01 07:14:54 +08:00
tests/convert/full/task.toml Outdated
@ -0,0 +40,4 @@
files.import = [ "tools/filelength" ]
# files to import into the sandbox
# key is the path in the host, value is the path in the sandbox
# e.g. this will copy `/home/tt/.config/joj/h7/Makefile` in host
manuel commented 2025-07-01 07:14:53 +08:00
Owner
Copy Link

if key is host and value sandbox, then example might be the other way around joj/tools/Makefile (not h7/Makefie) and sandbox is the value h7/Makefile?

if key is host and value sandbox, then example might be the other way around `joj/tools/Makefile` (not `h7/Makefie`) and sandbox is the value `h7/Makefile`?
张泊明518370910136 commented 2025-07-01 07:32:23 +08:00
Author
Owner
Copy Link

Yes, it is a typo, fixed.

Yes, it is a typo, fixed.
bomingzh marked this conversation as resolved
manuel reviewed 2025-07-01 07:17:58 +08:00
tests/convert/full/task.toml Outdated
@ -0,0 +48,4 @@
files.export = [ "yes.txt" ]
# whether to copy all files from the current working directory from host (i.e. the whole repo)
copy-in-cwd = true # default: true
manuel commented 2025-07-01 07:17:58 +08:00
Owner
Copy Link

maybe we should should add a warning NOT to change/setup those values unless stricly necessary?

maybe we should should add a warning NOT to change/setup those values unless stricly necessary?
张泊明518370910136 commented 2025-07-01 07:35:57 +08:00
Author
Owner
Copy Link

In theory, in the run stage of a compiled language, it should be set as false to improve performance. As the binary is exported in the previous stage, it will be automatically imported here. Should we remind TAs for this?

In theory, in the run stage of a compiled language, it should be set as false to improve performance. As the binary is exported in the previous stage, it will be automatically imported here. Should we remind TAs for this?
manuel commented 2025-07-01 07:53:41 +08:00
Owner
Copy Link

yes, agree.

but in fact my comment was about adding a comment above the options below (to change time/ram/etc.)

yes, agree. but in fact my comment was about adding a comment above the options below (to change time/ram/etc.)
张泊明518370910136 commented 2025-07-01 07:59:16 +08:00
Author
Owner
Copy Link

done.

done.
bomingzh marked this conversation as resolved
张泊明518370910136 added 1 commit 2025-07-01 07:32:31 +08:00
fix: typo
All checks were successful
build / build (pull_request) Successful in 1m51s
Details
build / build (push) Successful in 1m53s
Details
build / trigger-build-image (push) Has been skipped
Details
build / trigger-build-image (pull_request) Has been skipped
Details
a280e205d6
张泊明518370910136 added 1 commit 2025-07-01 07:44:04 +08:00
docs: explain empty groups.name
All checks were successful
build / build (pull_request) Successful in 2m5s
Details
build / build (push) Successful in 2m7s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
build / trigger-build-image (push) Has been skipped
Details
a0f4174bf8
张泊明518370910136 added 1 commit 2025-07-01 07:59:14 +08:00
docs: comments on copy-in-cwd & limit
All checks were successful
build / build (push) Successful in 1m31s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Successful in 1m35s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
7228083cfb
张泊明518370910136 force-pushed full-toml-sample from 7228083cfb to 852bac8653 2025-07-01 12:22:50 +08:00 Compare
张泊明518370910136 force-pushed full-toml-sample from 852bac8653 to df0bc226f0 2025-07-01 12:25:36 +08:00 Compare
张泊明518370910136 added 1 commit 2025-07-01 12:27:38 +08:00
fix: rebase error
All checks were successful
build / build (push) Successful in 2m46s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Successful in 2m54s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
99e66cb3ff
张泊明518370910136 changed title from docs: full toml sample to docs: full toml sample (#20) 2025-07-01 12:29:50 +08:00
张泊明518370910136 force-pushed full-toml-sample from 99e66cb3ff to 629a6cfdad 2025-07-01 12:38:00 +08:00 Compare
张泊明518370910136 added 1 commit 2025-07-01 12:43:35 +08:00
docs: hint on match keywords style parsers
All checks were successful
build / build (push) Successful in 1m53s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Successful in 2m1s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
1e2f1396b8
张泊明518370910136 force-pushed full-toml-sample from 1e2f1396b8 to 8b5907f86a 2025-07-03 21:20:29 +08:00 Compare
张泊明518370910136 force-pushed full-toml-sample from 8b5907f86a to e2262bc02c 2025-07-08 04:34:16 +08:00 Compare
张泊明518370910136 merged commit eac9100146 into master 2025-07-08 04:38:47 +08:00
张泊明518370910136 deleted branch full-toml-sample 2025-07-08 04:38:47 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: JOJ/JOJ3-config-generator#27
No description provided.
Delete Branch "full-toml-sample"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?