WIP: dev #6
No reviewers
张泊明518370910136
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: JOJ/JOJ3-config-generator#6
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "dev"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Are the problems solved?
can not pass
pre-commit run --all-files@bomingzh fixed
Resolve the warning in
pdm run test.Follow the underscore naming convention, do not use camel case.
The
libdir name is too ambiguous, named it as something likeprocessers.Rebase it to lastest master branch.
@ -0,0 +84,4 @@# FIXME: should be finalized when get into the servercurrent_file_path = Path(__file__).resolve()project_root = current_file_path.parents[2]file_path = f"{project_root}/tests/immutable_file/"hard coded path not acceptable
thats what I wanted to discuss, in what form would be better? @manuel @bomingzh
my suggestions is to add more fields related to this in
repo.tomlortask.toml, I think store it globally in some*.pyfile is still hardcodedjust let them enter path relative to project root for immutable files
giving prompt? Wouldn't it be better to export field in
*.tomlfile? they may accidnetally input wrong things I guessjust throw error on wrong input
I mean, they input
\home\tt\.config\instead of\home\tt\.config\jojsuch things may happen, but will cost time to figure out what happened? So I think better put them in*.toml.just make the dir relative to git repo root, if the file does not exist, throw error
any path in toml should probably be defined relative to
/home/tt/.config/jojand be in a subdirectory. this is where all config must be.then they can specify
projects/p2/.cang-tidyortool/compileusing
project_rootas too tricky as it could mean going up (../../) which is hard to read/figure out quickly.as all JOJ config files must be in
$HOME/.config/jojtaking it as root makes sense, is general, and consistent with the approach we have used so farbit mixed here, if fixed, can I hardcode it?
@ -0,0 +7,4 @@def remove_nulls(d: result.Config) -> result.Config:if isinstance(d, dict):Why it can be in different types as the type annotation says it is
result.Config?Sorry about this, I was still debugging on it last time I was on it. Will fix that.
@ -23,3 +20,1 @@stdout: Optional[CmdFile] = Nonestderr: Optional[CmdFile] = Nonecpu_limit: int = Field(0, serialization_alias="cpuLimit")args: list[str]Unify the use of
listorListeverywhere as we only support Python >=3.9 now.ok
@ -0,0 +1,1327 @@{what is this basic folder?
maybe my mistakes in
git rebase?@ -26,0 +31,4 @@"content": "","fileId": null,"name": null,"max": 4194304,null
yes,
remove_nullfunction need a small adjustmentdefault value problem in pydantic model
OK
@ -166,0 +1050,4 @@"with": {"default": {"args": ["./msan",is this file copied in?
@ -166,3 +1228,4 @@"showMemory": true}}]is the empty "gradingRepoName" in teapot dict expected?
@ -1,30 +1,137 @@task = "hw3 ex5"# p2 repo configmake this basic test as simple as possible, and create new test cases for each kind of stage
@ -5,1 +5,4 @@load_case("basic")test_basic()why?
to pass test locally, forgot to delete it
@ -29,4 +29,5 @@ def read_convert_files(def load_case(case_name: str) -> None:repo, task, expected_result = read_convert_files(case_name)result = convert(repo, task).model_dump(mode="json", by_alias=True)why modify this?
ah, I guess some incompatible within
convert()? to make sure actually the process is the same. If its not your wish i ll revert it@ -0,0 +1,118 @@task = "cc"remove it if it's not ready
We need to consider testing the generated task.json with JOJ3 here to make sure it actually works.
@bomingzh Any more feedback? I ll fix them all tonight.
b96383f2dcto47c46755e6Pull request closed