JOJ/JOJ3
25
5
Fork 0
Code Issues6 Pull Requests Actions Packages Projects Releases Wiki Activity

feat/reposize #56

Merged
张泊明518370910136 merged 8 commits from feat/reposize into master 2024-10-12 18:30:55 +08:00
Conversation 2 Commits 8 Files Changed 2 +5 -4
周赵嘉程521432910016 commented 2024-10-11 19:20:42 +08:00
Member
No description provided.
周赵嘉程521432910016 added 3 commits 2024-10-11 19:20:42 +08:00
周赵嘉程521432910016 added 1 commit 2024-10-11 19:30:23 +08:00
周赵嘉程521432910016 commented 2024-10-11 19:36:11 +08:00
Author
Member

This pr should be ready

https://focs.ji.sjtu.edu.cn/git/JOJ/JOJ3-examples/src/branch/healthcheck/reposize/expected.json

This pr should be ready https://focs.ji.sjtu.edu.cn/git/JOJ/JOJ3-examples/src/branch/healthcheck/reposize/expected.json
周赵嘉程521432910016 commented 2024-10-11 19:36:18 +08:00
Author
Member

@bomingzh

@bomingzh
周赵嘉程521432910016 changed title from WIP: feat/reposize to feat/reposize 2024-10-11 19:39:47 +08:00
张泊明518370910136 requested changes 2024-10-11 23:13:47 +08:00
Dismissed
pkg/healthcheck/reposize.go Outdated
@ -11,3 +11,3 @@
// RepoSize checks the size of the repository to determine if it is oversized.
// It executes the 'git count-objects -v' command to obtain the size information,
func RepoSize() error {
func RepoSize(conf_size float64) error {
张泊明518370910136 commented 2024-10-11 23:12:44 +08:00
Owner

We use camel case for variables in Go project.

We use camel case for variables in Go project.
zzjc123 marked this conversation as resolved
pkg/healthcheck/reposize.go Outdated
@ -36,2 +36,2 @@
if sum > 2048 {
return fmt.Errorf("Repository larger than 2MB. Please clean up or contact the teaching team.")
if sum > int(conf_size*1024) {
return fmt.Errorf("Repository larger than %f M. Please clean up or contact the teaching team.", conf_size)
张泊明518370910136 commented 2024-10-11 23:12:27 +08:00
Owner

We should use %.1f Mib here for clearance.

We should use `%.1f Mib` here for clearance.
zzjc123 marked this conversation as resolved
周赵嘉程521432910016 added 1 commit 2024-10-12 17:59:30 +08:00
周赵嘉程521432910016 added 1 commit 2024-10-12 17:59:41 +08:00
周赵嘉程521432910016 added 1 commit 2024-10-12 18:01:23 +08:00
周赵嘉程521432910016 requested review from 张泊明518370910136 2024-10-12 18:06:47 +08:00
张泊明518370910136 added 1 commit 2024-10-12 18:27:39 +08:00
张泊明518370910136 approved these changes 2024-10-12 18:28:48 +08:00
张泊明518370910136 scheduled this pull request to auto merge when all checks succeed 2024-10-12 18:29:37 +08:00
张泊明518370910136 merged commit 901290d263 into master 2024-10-12 18:30:55 +08:00
张泊明518370910136 deleted branch feat/reposize 2024-10-12 18:30:55 +08:00
Sign in to join this conversation.
No reviewers
张泊明518370910136
No Label
bug
component
executor
component
framework
component
parser
component
UI
duplicate
enhancement
help wanted
invalid
priority
p0
priority
p1
priority
p2
priority
p3
question
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: JOJ/JOJ3#56
No description provided.
Delete Branch "feat/reposize"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?