feat/reposize #56

Merged
张泊明518370910136 merged 8 commits from feat/reposize into master 2024-10-12 18:30:55 +08:00
No description provided.
周赵嘉程521432910016 added 3 commits 2024-10-11 19:20:42 +08:00
feat(healthcheck/reposize): customize repo size
Some checks failed
build / build (push) Failing after 1m4s
build / trigger-build-image (push) Has been skipped
8fb707e07d
fix(healthcheck/reposize): unit
Some checks failed
build / build (push) Failing after 32s
build / trigger-build-image (push) Has been skipped
57c50c4f68
fix(healthcheck/reposize): unit
All checks were successful
build / build (push) Successful in 1m3s
build / trigger-build-image (push) Has been skipped
build / build (pull_request) Successful in 1m3s
build / trigger-build-image (pull_request) Has been skipped
c3ed1413a5
周赵嘉程521432910016 added 1 commit 2024-10-11 19:30:23 +08:00
fix(healthcheck/reposize): unit
All checks were successful
build / build (push) Successful in 1m2s
build / trigger-build-image (push) Has been skipped
build / build (pull_request) Successful in 1m3s
build / trigger-build-image (pull_request) Has been skipped
d38876e016
Author
Member
This pr should be ready https://focs.ji.sjtu.edu.cn/git/JOJ/JOJ3-examples/src/branch/healthcheck/reposize/expected.json
Author
Member
@bomingzh
周赵嘉程521432910016 changed title from WIP: feat/reposize to feat/reposize 2024-10-11 19:39:47 +08:00
张泊明518370910136 requested changes 2024-10-11 23:13:47 +08:00
Dismissed
@ -11,3 +11,3 @@
// RepoSize checks the size of the repository to determine if it is oversized.
// It executes the 'git count-objects -v' command to obtain the size information,
func RepoSize() error {
func RepoSize(conf_size float64) error {

We use camel case for variables in Go project.

We use camel case for variables in Go project.
zzjc123 marked this conversation as resolved
@ -36,2 +36,2 @@
if sum > 2048 {
return fmt.Errorf("Repository larger than 2MB. Please clean up or contact the teaching team.")
if sum > int(conf_size*1024) {
return fmt.Errorf("Repository larger than %f M. Please clean up or contact the teaching team.", conf_size)

We should use %.1f Mib here for clearance.

We should use `%.1f Mib` here for clearance.
zzjc123 marked this conversation as resolved
周赵嘉程521432910016 added 1 commit 2024-10-12 17:59:30 +08:00
fix(healthcheck/reposize): output format
Some checks failed
build / trigger-build-image (push) Blocked by required conditions
build / build (push) Has been cancelled
build / build (pull_request) Failing after 1m14s
build / trigger-build-image (pull_request) Has been skipped
dd40a17476
周赵嘉程521432910016 added 1 commit 2024-10-12 17:59:41 +08:00
Merge branch 'master' into feat/reposize
Some checks failed
build / build (pull_request) Failing after 1m13s
build / build (push) Failing after 1m15s
build / trigger-build-image (pull_request) Has been skipped
build / trigger-build-image (push) Has been skipped
74ad5d6a8a
周赵嘉程521432910016 added 1 commit 2024-10-12 18:01:23 +08:00
fix(healthcheck/reposize): camel name style
All checks were successful
build / build (push) Successful in 1m13s
build / trigger-build-image (push) Has been skipped
build / build (pull_request) Successful in 1m11s
build / trigger-build-image (pull_request) Has been skipped
aa2969a82f
周赵嘉程521432910016 requested review from 张泊明518370910136 2024-10-12 18:06:47 +08:00
张泊明518370910136 added 1 commit 2024-10-12 18:27:39 +08:00
fix: typo
All checks were successful
build / build (push) Successful in 1m8s
build / build (pull_request) Successful in 1m7s
build / trigger-build-image (push) Has been skipped
build / trigger-build-image (pull_request) Has been skipped
acc0ccf88c
张泊明518370910136 approved these changes 2024-10-12 18:28:48 +08:00
张泊明518370910136 scheduled this pull request to auto merge when all checks succeed 2024-10-12 18:29:37 +08:00
张泊明518370910136 merged commit 901290d263 into master 2024-10-12 18:30:55 +08:00
张泊明518370910136 deleted branch feat/reposize 2024-10-12 18:30:55 +08:00
Sign in to join this conversation.
No description provided.