JOJ/JOJ3
25
6
Fork 1
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: skip git module for non ascii check #95

Merged
张泊明518370910136 merged 1 commits from feat/submodule into master 2026-04-22 17:07:17 +08:00
Conversation 3 Commits 1 Files Changed 1 +47 -4
周赵嘉程521432910016 commented 2025-11-07 21:07:13 +08:00
Member
Copy Link

Skip git submodule non ascii check

check with by directly running ./build/repo-health-checker at root after build

Skip git submodule non ascii check check with by directly running `./build/repo-health-checker` at root after build
周赵嘉程521432910016 added the
enhancement
component
framework
 labels 2025-11-07 21:07:13 +08:00
周赵嘉程521432910016 self-assigned this 2025-11-07 21:07:13 +08:00
张泊明518370910136 was assigned by 周赵嘉程521432910016 2025-11-07 21:07:13 +08:00
manuel was assigned by 周赵嘉程521432910016 2025-11-07 21:07:13 +08:00
周赵嘉程521432910016 added 1 commit 2025-11-07 21:07:14 +08:00
feat: skip git module for non ascii check
All checks were successful
build / build (push) Successful in 2m49s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Successful in 3m32s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
f04b18189a
周赵嘉程521432910016 requested review from manuel 2025-11-07 21:07:23 +08:00
周赵嘉程521432910016 requested review from 张泊明518370910136 2025-11-07 21:07:23 +08:00
周赵嘉程521432910016 changed title from feat: skip git module for non ascii check to WIP: feat: skip git module for non ascii check 2025-11-07 21:10:10 +08:00
周赵嘉程521432910016 commented 2025-11-07 21:12:38 +08:00
Author
Member
Copy Link

tested on repo without submodule without error

tested on repo without submodule without error
周赵嘉程521432910016 changed title from WIP: feat: skip git module for non ascii check to feat: skip git module for non ascii check 2025-11-07 21:12:45 +08:00
张泊明518370910136 commented 2025-11-09 04:43:36 +08:00
Owner
Copy Link

@manuel Should we ignore it by default or with a config?

@manuel Should we ignore it by default or with a config?
manuel commented 2025-11-09 09:35:34 +08:00
Owner
Copy Link

@manuel Should we ignore it by default or with a config?

submodules are unlikely to be used in many courses and if they are used they will unlikely contain the students' work. so i would say by default we can ignore non-ascii for submodules. a config switch might still be helpful in case we need it one day...

> @manuel Should we ignore it by default or with a config? submodules are unlikely to be used in many courses and if they are used they will unlikely contain the students' work. so i would say by default we can ignore non-ascii for submodules. a config switch might still be helpful in case we need it one day...
张泊明518370910136 approved these changes 2025-11-09 15:42:29 +08:00
Dismissed
张泊明518370910136 removed review request for manuel 2025-11-19 19:11:46 +08:00
张泊明518370910136 force-pushed feat/submodule from f04b18189a to ea09b4c781 2026-03-13 15:44:35 +08:00 Compare
张泊明518370910136 force-pushed feat/submodule from ea09b4c781 to 0b9e384a73 2026-04-06 17:52:45 +08:00 Compare
周赵嘉程521432910016 force-pushed feat/submodule from 0b9e384a73 to 64bc267300 2026-04-07 20:11:01 +08:00 Compare
周赵嘉程521432910016 added 1 commit 2026-04-07 20:30:34 +08:00
feat(non-ascii): skipp non-ascii check in the submodule
All checks were successful
build / build (push) Successful in 8m23s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Successful in 5m4s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
565791d06f
周赵嘉程521432910016 dismissed bomingzh’s review 2026-04-07 20:30:34 +08:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

张泊明518370910136 approved these changes 2026-04-22 15:49:15 +08:00
张泊明518370910136 merged commit 9d75e359af into master 2026-04-22 17:07:17 +08:00
张泊明518370910136 deleted branch feat/submodule 2026-04-22 17:09:10 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
张泊明518370910136
Labels
Clear labels   
bug

Something is not working

  
component
executor
executors in different stages

  
component
framework
software architecture

  
component
parser
parsers in different stages

  
component
UI
drone, gitea, and config interfaces

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
priority
p0

  
priority
p1

  
priority
p2

  
priority
p3

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
component
executor
component
framework
component
parser
component
UI
duplicate
enhancement
help wanted
invalid
priority
p0
priority
p1
priority
p2
priority
p3
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
周赵嘉程521432910016
张泊明518370910136
manuel
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: JOJ/JOJ3#95
No description provided.
Delete Branch "feat/submodule"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?