JOJ/JOJ3
25
6
Fork 0
Code Issues 6 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat: skip git module for non ascii check #95

Open
周赵嘉程521432910016 wants to merge 1 commits from feat/submodule into master
pull from: feat/submodule
merge into: JOJ:master
Conversation 3 Commits 1 Files Changed 1 +47 -4
周赵嘉程521432910016 commented 2025-11-07 21:07:13 +08:00
Member
Copy Link

Skip git submodule non ascii check

check with by directly running ./build/repo-health-checker at root after build

Skip git submodule non ascii check check with by directly running `./build/repo-health-checker` at root after build
周赵嘉程521432910016 added the
enhancement
component
framework
 labels 2025-11-07 21:07:13 +08:00
周赵嘉程521432910016 self-assigned this 2025-11-07 21:07:13 +08:00
张泊明518370910136 was assigned by 周赵嘉程521432910016 2025-11-07 21:07:13 +08:00
manuel was assigned by 周赵嘉程521432910016 2025-11-07 21:07:13 +08:00
周赵嘉程521432910016 added 1 commit 2025-11-07 21:07:14 +08:00
feat: skip git module for non ascii check
All checks were successful
build / build (push) Successful in 2m49s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Successful in 3m32s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
f04b18189a
周赵嘉程521432910016 requested review from manuel 2025-11-07 21:07:23 +08:00
周赵嘉程521432910016 requested review from 张泊明518370910136 2025-11-07 21:07:23 +08:00
周赵嘉程521432910016 changed title from feat: skip git module for non ascii check to WIP: feat: skip git module for non ascii check 2025-11-07 21:10:10 +08:00
周赵嘉程521432910016 commented 2025-11-07 21:12:38 +08:00
Author
Member
Copy Link

tested on repo without submodule without error

tested on repo without submodule without error
周赵嘉程521432910016 changed title from WIP: feat: skip git module for non ascii check to feat: skip git module for non ascii check 2025-11-07 21:12:45 +08:00
张泊明518370910136 commented 2025-11-09 04:43:36 +08:00
Owner
Copy Link

@manuel Should we ignore it by default or with a config?

@manuel Should we ignore it by default or with a config?
manuel commented 2025-11-09 09:35:34 +08:00
Owner
Copy Link

@manuel Should we ignore it by default or with a config?

submodules are unlikely to be used in many courses and if they are used they will unlikely contain the students' work. so i would say by default we can ignore non-ascii for submodules. a config switch might still be helpful in case we need it one day...

> @manuel Should we ignore it by default or with a config? submodules are unlikely to be used in many courses and if they are used they will unlikely contain the students' work. so i would say by default we can ignore non-ascii for submodules. a config switch might still be helpful in case we need it one day...
张泊明518370910136 approved these changes 2025-11-09 15:42:29 +08:00
张泊明518370910136 removed review request for manuel 2025-11-19 19:11:46 +08:00
All checks were successful
build / build (push) Successful in 2m49s
Required
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Successful in 3m32s
Required
Details
build / trigger-build-image (pull_request) Has been skipped
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/submodule:feat/submodule
git checkout feat/submodule
Sign in to join this conversation.
Reviewers
No reviewers
张泊明518370910136
Labels
Clear labels   
bug

Something is not working

  
component
executor
executors in different stages

  
component
framework
software architecture

  
component
parser
parsers in different stages

  
component
UI
drone, gitea, and config interfaces

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
priority
p0

  
priority
p1

  
priority
p2

  
priority
p3

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
component
executor
component
framework
component
parser
component
UI
duplicate
enhancement
help wanted
invalid
priority
p0
priority
p1
priority
p2
priority
p3
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
周赵嘉程521432910016
张泊明518370910136
manuel
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: JOJ/JOJ3#95
No description provided.
Delete Branch "feat/submodule"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?