JOJ/JOJ3
24
5
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: get release tag from msg scope #49

Merged
张泊明518370910136 merged 2 commits from feat/releaseByScope into master 2024-10-08 11:16:15 +08:00
Conversation 4 Commits 2 Files Changed 2 +40 -23
周赵嘉程521432910016 commented 2024-10-08 10:27:37 +08:00
Member
Copy Link

Check release tag from msg scope.

Check release tag from msg scope.
周赵嘉程521432910016 added 1 commit 2024-10-08 10:27:37 +08:00
feat: get release tag from msg scope
Some checks failed
build / build (push) Failing after 1m40s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Failing after 1m41s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
d211e576ba
周赵嘉程521432910016 added 1 commit 2024-10-08 10:52:55 +08:00
fix: default value
All checks were successful
build / build (push) Successful in 1m38s
Details
build / build (pull_request) Successful in 1m41s
Details
build / trigger-build-image (push) Has been skipped
Details
build / trigger-build-image (pull_request) Has been skipped
Details
8af5aac645
周赵嘉程521432910016 commented 2024-10-08 10:54:03 +08:00
Author
Member
Copy Link

Is this the behavior you want @manuel
8af5aac645/pkg/healthcheck/tag.go

Is this the behavior you want @manuel https://focs.ji.sjtu.edu.cn/git/JOJ/JOJ3/src/commit/8af5aac6454000ef9978489f7973b8b7ff239f34/pkg/healthcheck/tag.go
manuel commented 2024-10-08 10:57:55 +08:00
Owner
Copy Link

Is this the behavior you want @manuel
8af5aac645/pkg/healthcheck/tag.go

it looks like it! lets see how in works in practive

> Is this the behavior you want @manuel > https://focs.ji.sjtu.edu.cn/git/JOJ/JOJ3/src/commit/8af5aac6454000ef9978489f7973b8b7ff239f34/pkg/healthcheck/tag.go it looks like it! lets see how in works in practive
周赵嘉程521432910016 commented 2024-10-08 10:58:31 +08:00
Author
Member
Copy Link

ok i will update the test case soon.

ok i will update the test case soon.
周赵嘉程521432910016 commented 2024-10-08 11:13:37 +08:00
Author
Member
Copy Link

@bomingzh plz review the code.

@bomingzh plz review the code.
张泊明518370910136 changed title from WIP: feat: get release tag from msg scope to feat: get release tag from msg scope 2024-10-08 11:15:21 +08:00
张泊明518370910136 approved these changes 2024-10-08 11:15:59 +08:00
张泊明518370910136 merged commit 3f9ec1a71d into master 2024-10-08 11:16:15 +08:00
张泊明518370910136 deleted branch feat/releaseByScope 2024-10-08 11:16:15 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
张泊明518370910136
Labels
Clear labels   
bug

Something is not working

  
component
executor
executors in different stages

  
component
framework
software architecture

  
component
parser
parsers in different stages

  
component
UI
drone, gitea, and config interfaces

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
priority
p0

  
priority
p1

  
priority
p2

  
priority
p3

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
component
executor
component
framework
component
parser
component
UI
duplicate
enhancement
help wanted
invalid
priority
p0
priority
p1
priority
p2
priority
p3
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: JOJ/JOJ3#49
No description provided.
Delete Branch "feat/releaseByScope"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?