JOJ/JOJ3
24
5
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

feat/reposize #56

Merged
张泊明518370910136 merged 8 commits from feat/reposize into master 2024-10-12 18:30:55 +08:00
Conversation 2 Commits 8 Files Changed 2 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit aa2969a82f - Show all commits

6
pkg/healthcheck/reposize.go
View File

@ -10,7 +10,7 @@ import (
// RepoSize checks the size of the repository to determine if it is oversized.
// It executes the 'git count-objects -v' command to obtain the size information,
func RepoSize(conf_size float64) error {
func RepoSize(confSize float64) error {
zzjc123 marked this conversation as resolved Outdated
张泊明518370910136 commented 2024-10-11 23:12:44 +08:00
Outdated
Review
Copy Link

We use camel case for variables in Go project.

We use camel case for variables in Go project.
// TODO: reimplement here when go-git is available
// https://github.com/go-git/go-git/blob/master/COMPATIBILITY.md
cmd := exec.Command("git", "count-objects", "-v")
@ -33,8 +33,8 @@ func RepoSize(conf_size float64) error {
sum += size
}
}
if sum > int(conf_size*1024) {
return fmt.Errorf("Repository larger than %.1f Mib. Please clean up or contact the teaching team.", conf_size)
if sum > int(confSize*1024) {
return fmt.Errorf("Repository larger than %.1f Mib. Please clean up or contact the teaching team.", confSize)
zzjc123 marked this conversation as resolved Outdated
张泊明518370910136 commented 2024-10-11 23:12:27 +08:00
Outdated
Review
Copy Link

We should use %.1f Mib here for clearance.

We should use `%.1f Mib` here for clearance.
}
return nil
}