JOJ/JOJ3
24
5
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(healthcheck/releasetag): recommended tag listcheck #57

Closed
周赵嘉程521432910016 wants to merge 8 commits from feat/releasetag into master
pull from: feat/releasetag
merge into: JOJ:master
Conversation 1 Commits 8 Files Changed 2 +40 -11
周赵嘉程521432910016 commented 2024-10-11 19:21:08 +08:00
Member
Copy Link
No description provided.
周赵嘉程521432910016 added 1 commit 2024-10-11 19:21:09 +08:00
feat(healthcheck/releasetag): recommended tag listcheck
Some checks failed
build / build (push) Failing after 32s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Failing after 35s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
1e0cbb48f0
周赵嘉程521432910016 added 1 commit 2024-10-11 19:27:29 +08:00
fix(healthcheck/releasetag): args
Some checks failed
build / build (pull_request) Failing after 1m14s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
build / build (push) Failing after 1m19s
Details
build / trigger-build-image (push) Has been skipped
Details
762b1aa49d
周赵嘉程521432910016 added 1 commit 2024-10-13 11:38:45 +08:00
Merge branch 'master' into feat/releasetag
All checks were successful
build / build (push) Successful in 1m5s
Details
build / build (pull_request) Successful in 1m4s
Details
build / trigger-build-image (push) Has been skipped
Details
build / trigger-build-image (pull_request) Has been skipped
Details
a5767cf040
周赵嘉程521432910016 added 2 commits 2024-10-13 12:39:23 +08:00
Merge branch 'master' into feat/releasetag
Some checks failed
build / build (push) Failing after 35s
Details
build / build (pull_request) Failing after 34s
Details
build / trigger-build-image (push) Has been skipped
Details
build / trigger-build-image (pull_request) Has been skipped
Details
e7e24f7c8f
周赵嘉程521432910016 added 1 commit 2024-10-13 12:45:05 +08:00
fix(healthcheck/release): style check
Some checks failed
build / build (push) Failing after 36s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Failing after 32s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
742d1f07c0
周赵嘉程521432910016 added 1 commit 2024-10-13 12:51:42 +08:00
fix(healthcheck/release): bad function call
All checks were successful
build / build (push) Successful in 1m5s
Details
build / trigger-build-image (push) Has been skipped
Details
build / build (pull_request) Successful in 1m7s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
367622da35
周赵嘉程521432910016 changed title from WIP: feat(healthcheck/releasetag): recommended tag listcheck to feat(healthcheck/releasetag): recommended tag listcheck 2024-10-13 14:41:21 +08:00
周赵嘉程521432910016 added 1 commit 2024-10-13 14:41:26 +08:00
Merge branch 'master' into feat/releasetag
All checks were successful
build / build (pull_request) Successful in 1m6s
Details
build / build (push) Successful in 1m10s
Details
build / trigger-build-image (pull_request) Has been skipped
Details
build / trigger-build-image (push) Has been skipped
Details
04ee64a79c
周赵嘉程521432910016 requested review from 张泊明518370910136 2024-10-13 14:42:46 +08:00
张泊明518370910136 commented 2024-10-13 16:33:52 +08:00
Owner
Copy Link

Tags are already checked here:

cmd/joj3/conf/conf.go Line 213 in 92d88091ff
if tag != "" && conventionalCommit.Scope != tag {
.

As we force tag == scope in msg to run JOJ3, there is no need to check it here.

Tags are already checked here: https://focs.ji.sjtu.edu.cn/git/JOJ/JOJ3/src/commit/92d88091ff3780c71df5ca9f0e68d521db290c76/cmd/joj3/conf/conf.go#L213. As we force `tag == scope in msg` to run JOJ3, there is no need to check it here.
All checks were successful
build / build (pull_request) Successful in 1m6s
Required
Details
build / build (push) Successful in 1m10s
Required
Details
build / trigger-build-image (pull_request) Has been skipped
Details
build / trigger-build-image (push) Has been skipped
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
张泊明518370910136
Labels
Clear labels   
bug

Something is not working

  
component
executor
executors in different stages

  
component
framework
software architecture

  
component
parser
parsers in different stages

  
component
UI
drone, gitea, and config interfaces

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
priority
p0

  
priority
p1

  
priority
p2

  
priority
p3

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
component
executor
component
framework
component
parser
component
UI
duplicate
enhancement
help wanted
invalid
priority
p0
priority
p1
priority
p2
priority
p3
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: JOJ/JOJ3#57
No description provided.
Delete Branch "feat/releasetag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?