李衍志523370910113 jon-lee
2 Followers · 1 Following
  • 523370910113
  • Joined on 2023-09-10
Repositories Projects Packages Public Activity Starred Repositories
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2024-11-12 23:17:55 +08:00
8ca95d15af feat: change path & add task.type in toml
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2024-11-12 17:21:00 +08:00
ba503ee8d8 chore: change camel case naming
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2024-11-12 17:14:58 +08:00
1eb9d5747a chore: remove redundant import
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2024-11-12 16:58:11 +08:00
4de423679e chore: remove redundant import
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2024-11-12 16:54:10 +08:00
b86d7f46dc chore: remove redundant folder
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2024-11-12 16:53:22 +08:00
ef4ccfff9d chore: remove redundant import & rename folder
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2024-11-12 16:51:11 +08:00
78f1b8c08f Revert "chore: remove redundant import & rename folder"
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2024-11-12 16:47:44 +08:00
5a8ea67bc8 chore: remove redundant import & rename folder
李衍志523370910113 pushed to dev at JOJ/JOJ3-config-generator 2024-11-12 16:30:06 +08:00
16d906464e rebase with master
cb34dced50 fix: type annotation
b6e7cd2f1d fix: pass test
eab68a4f81 fix: file path setting
e725bc43a4 fix: shell split command args
Compare 52 commits »
李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#6 2024-11-12 14:32:53 +08:00
WIP: dev

bit mixed here, if fixed, can I hardcode it?

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#6 2024-11-12 13:37:08 +08:00
WIP: dev

I mean, they input \home\tt\.config\ instead of \home\tt\.config\joj such things may happen, but will cost time to figure out what happened? So I think better put them in *.toml.

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#6 2024-11-12 13:02:22 +08:00
WIP: dev

OK

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#6 2024-11-12 13:00:03 +08:00
WIP: dev

giving prompt? Wouldn't it be better to export field in *.toml file? they may accidnetally input wrong things I guess

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#6 2024-11-12 12:35:42 +08:00
WIP: dev

@bomingzh Any more feedback? I ll fix them all tonight.

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#6 2024-11-12 12:34:59 +08:00
WIP: dev

ah, I guess some incompatible within convert()? to make sure actually the process is the same. If its not your wish i ll revert it

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#6 2024-11-12 12:34:13 +08:00
WIP: dev

to pass test locally, forgot to delete it

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#6 2024-11-12 12:33:20 +08:00
WIP: dev

yes, remove_null function need a small adjustment

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#6 2024-11-12 12:32:59 +08:00
WIP: dev

maybe my mistakes in git rebase?

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#6 2024-11-12 12:32:22 +08:00
WIP: dev

ok

李衍志523370910113 commented on pull request JOJ/JOJ3-config-generator#6 2024-11-12 12:32:13 +08:00
WIP: dev

Sorry about this, I was still debugging on it last time I was on it. Will fix that.