周赵嘉程521432910016 zzjc123
  • 521432910016
  • Joined on 2022-09-12
周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 18:40:58 +08:00
fix/forbidden (#58)

add a simple case here but I'm afraid that it is too simple. https://focs.ji.sjtu.edu.cn/git/JOJ/JOJ3-examples/src/branch/healthcheck/forbiddenfile

can anyone think about some more tricky cases.

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 18:23:43 +08:00
fix/forbidden (#58)

seems easier than i think @bomingzh plz check it. i don't sure is this function correctly implemented in package.

周赵嘉程521432910016 pushed to fix/forbidden at JOJ/JOJ3 2024-10-17 18:20:20 +08:00
44e3feb5c6 feat(healthcheck/forbidden): gitignore in subdir
周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 17:14:51 +08:00
fix/forbidden (#58)

may be done this weekend

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 17:13:43 +08:00
fix/forbidden (#58)

may need some time for this feature. A little busy recently.

The .gitignore file may appear in sub-dirs, you also need to check them

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 16:57:59 +08:00
fix/forbidden (#58)

Change to locallist and make it work as a gitignore file?

what if the gitignore is nonsense? Not every course provide unchangeable gitignore

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 16:56:05 +08:00
fix/forbidden (#58)

ignore the /w/tmp/?

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 16:55:36 +08:00
fix/forbidden (#58)

Also, add an option to healthcheck parser for stdout and stderr as we need to put them to /tmp/stdout and /tmp/stderr.

not sure what did you mean, can you explain more detailedly?

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 16:54:27 +08:00
fix/forbidden (#58)

So what's the default pattern if no gitignore? Warn student add a gitignore or set root as default value?

周赵嘉程521432910016 pushed to fix/forbidden at JOJ/JOJ3 2024-10-17 16:13:30 +08:00
f6012bdd5e fix(healthcheck/forbidden): remove unused option
周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 16:05:28 +08:00
fix/forbidden (#58)

should fix issue in https://focs.ji.sjtu.edu.cn/git/engr151-24fa/hteam-05

❯ ../JOJ3/build/healthcheck -root=.
### Forbidden File Check Failed:
The following forbidden files were found:…
周赵嘉程521432910016 commented on issue JOJ/JOJ3#61 2024-10-17 15:32:17 +08:00
healthcheck not working

😓

周赵嘉程521432910016 commented on pull request JOJ/JOJ3#60 2024-10-17 15:29:08 +08:00
fix/forbidden (#58)

#58

周赵嘉程521432910016 created pull request JOJ/JOJ3#60 2024-10-17 15:28:40 +08:00
WIP: fix/forbidden
周赵嘉程521432910016 commented on issue JOJ/JOJ3#58 2024-10-17 15:27:57 +08:00
healthcheck needs to check whether all files in the repo respect .gitignore file

also the healthcheck (or repo-healthcheck binary)

Note: to avoid the influence of stdout and stderr generated by go-judge, we need to put them to /tmp/stdout and /tmp/stderr when running repo…

周赵嘉程521432910016 pushed to fix/forbidden at JOJ/JOJ3 2024-10-17 15:26:50 +08:00
64cbeef111 fix(healthcheck/forbidden): relative path
周赵嘉程521432910016 pushed to fix/forbidden at JOJ/JOJ3 2024-10-17 15:01:39 +08:00
83b6cb6b2c fix(healthcheck/forbidden): skip .
周赵嘉程521432910016 pushed to fix/forbidden at JOJ/JOJ3 2024-10-17 14:46:06 +08:00
84e168dad6 refractor(healthcheck/forbidden): use go-gitignore package
周赵嘉程521432910016 pushed to feat/releasetag at JOJ/JOJ3 2024-10-13 14:41:26 +08:00
04ee64a79c Merge branch 'master' into feat/releasetag
92d88091ff feat(cmd/joj3): check tag on non-empty
Compare 2 commits »
周赵嘉程521432910016 pushed to feat/releasetag at JOJ/JOJ3 2024-10-13 12:51:42 +08:00
367622da35 fix(healthcheck/release): bad function call